Address Copilot review feedback
Localize the "More options" aria-label in OngoingTaskContextMenu via the translation ref, and add a migration note to the changeset about direct FormFieldBlueprint attachments no longer being consumed. Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com> Made-with: Cursor
This commit is contained in:
@@ -2,4 +2,4 @@
|
||||
'@backstage/plugin-scaffolder': patch
|
||||
---
|
||||
|
||||
Fixed the layout of the scaffolder plugin in the new frontend system to use the new page layout.
|
||||
Fixed the layout of the scaffolder plugin in the new frontend system to use the new page layout. Direct `FormFieldBlueprint` attachments to the scaffolder page are no longer consumed, custom form fields should instead be provided through the form fields API.
|
||||
|
||||
@@ -82,7 +82,7 @@ export function OngoingTaskContextMenu(props: OngoingTaskContextMenuProps) {
|
||||
<ButtonIcon
|
||||
variant="tertiary"
|
||||
icon={<RiMore2Line />}
|
||||
aria-label="More options"
|
||||
aria-label={t('ongoingTask.contextMenu.moreOptions')}
|
||||
/>
|
||||
<Menu placement="bottom end">
|
||||
<MenuItem
|
||||
|
||||
@@ -182,6 +182,7 @@ export const scaffolderTranslationRef = createTranslationRef({
|
||||
hideLogsButtonTitle: 'Hide Logs',
|
||||
showLogsButtonTitle: 'Show Logs',
|
||||
contextMenu: {
|
||||
moreOptions: 'More options',
|
||||
hideLogs: 'Hide Logs',
|
||||
showLogs: 'Show Logs',
|
||||
hideButtonBar: 'Hide Button Bar',
|
||||
|
||||
Reference in New Issue
Block a user