From fc02749b861108ed1f0a02370c5637bca1c25d24 Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Fri, 20 Mar 2026 15:38:43 +0100
Subject: [PATCH] Address Copilot review feedback

Localize the "More options" aria-label in OngoingTaskContextMenu via
the translation ref, and add a migration note to the changeset about
direct FormFieldBlueprint attachments no longer being consumed.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
---
 .changeset/scaffolder-nfs-page-layout.md                        | 2 +-
 .../src/components/OngoingTask/OngoingTaskContextMenu.tsx       | 2 +-
 plugins/scaffolder/src/translation.ts                           | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/.changeset/scaffolder-nfs-page-layout.md b/.changeset/scaffolder-nfs-page-layout.md
index 2f0f848e40..f282f699bb 100644
--- a/.changeset/scaffolder-nfs-page-layout.md
+++ b/.changeset/scaffolder-nfs-page-layout.md
@@ -2,4 +2,4 @@
 '@backstage/plugin-scaffolder': patch
 ---
 
-Fixed the layout of the scaffolder plugin in the new frontend system to use the new page layout.
+Fixed the layout of the scaffolder plugin in the new frontend system to use the new page layout. Direct `FormFieldBlueprint` attachments to the scaffolder page are no longer consumed, custom form fields should instead be provided through the form fields API.
diff --git a/plugins/scaffolder/src/components/OngoingTask/OngoingTaskContextMenu.tsx b/plugins/scaffolder/src/components/OngoingTask/OngoingTaskContextMenu.tsx
index 9539838590..86f2238a38 100644
--- a/plugins/scaffolder/src/components/OngoingTask/OngoingTaskContextMenu.tsx
+++ b/plugins/scaffolder/src/components/OngoingTask/OngoingTaskContextMenu.tsx
@@ -82,7 +82,7 @@ export function OngoingTaskContextMenu(props: OngoingTaskContextMenuProps) {
           <ButtonIcon
             variant="tertiary"
             icon={<RiMore2Line />}
-            aria-label="More options"
+            aria-label={t('ongoingTask.contextMenu.moreOptions')}
           />
           <Menu placement="bottom end">
             <MenuItem
diff --git a/plugins/scaffolder/src/translation.ts b/plugins/scaffolder/src/translation.ts
index d0f332e2fa..0b19082d8f 100644
--- a/plugins/scaffolder/src/translation.ts
+++ b/plugins/scaffolder/src/translation.ts
@@ -182,6 +182,7 @@ export const scaffolderTranslationRef = createTranslationRef({
       hideLogsButtonTitle: 'Hide Logs',
       showLogsButtonTitle: 'Show Logs',
       contextMenu: {
+        moreOptions: 'More options',
         hideLogs: 'Hide Logs',
         showLogs: 'Show Logs',
         hideButtonBar: 'Hide Button Bar',