Apply suggestions from code review
Co-authored-by: Vincenzo Scamporlino <vincenzos@spotify.com> Signed-off-by: Andreas Berger <Andy2003@users.noreply.github.com>
This commit is contained in:
@@ -2,7 +2,4 @@
|
||||
'@backstage/plugin-catalog': minor
|
||||
---
|
||||
|
||||
Harmonize `CatalogTable`
|
||||
|
||||
- Show pagination text for `OffsetPagination`
|
||||
- Do not show paging if there is only one page
|
||||
Show the pagination text for the offset-paginated catalog table, and remove the pagination bar from the top of the `CatalogTable` when pagination is enabled.
|
||||
|
||||
@@ -195,7 +195,6 @@ export const CatalogTable = (props: CatalogTableProps) => {
|
||||
|
||||
const actions = props.actions || defaultActions;
|
||||
const options: TableProps['options'] = {
|
||||
paginationPosition: 'both',
|
||||
actionsColumnIndex: -1,
|
||||
loadingType: 'linear' as const,
|
||||
showEmptyDataSourceMessage: !loading,
|
||||
|
||||
Reference in New Issue
Block a user