From eef2c5c3fdc2817c1957517751bbf5cf0d6ac72a Mon Sep 17 00:00:00 2001 From: Andreas Berger Date: Wed, 7 May 2025 11:13:53 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Vincenzo Scamporlino Signed-off-by: Andreas Berger --- .changeset/funny-papayas-tell.md | 5 +---- plugins/catalog/src/components/CatalogTable/CatalogTable.tsx | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/.changeset/funny-papayas-tell.md b/.changeset/funny-papayas-tell.md index 8931c7a96f..98beaf89e0 100644 --- a/.changeset/funny-papayas-tell.md +++ b/.changeset/funny-papayas-tell.md @@ -2,7 +2,4 @@ '@backstage/plugin-catalog': minor --- -Harmonize `CatalogTable` - -- Show pagination text for `OffsetPagination` -- Do not show paging if there is only one page +Show the pagination text for the offset-paginated catalog table, and remove the pagination bar from the top of the `CatalogTable` when pagination is enabled. diff --git a/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx b/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx index 8cce9ff317..464688c590 100644 --- a/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx +++ b/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx @@ -195,7 +195,6 @@ export const CatalogTable = (props: CatalogTableProps) => { const actions = props.actions || defaultActions; const options: TableProps['options'] = { - paginationPosition: 'both', actionsColumnIndex: -1, loadingType: 'linear' as const, showEmptyDataSourceMessage: !loading,