Merge pull request #903 from spotify/rugvip/buildfix

github/workflows: fix build step to include dependencies as well

.github/workflows/frontend.yml

@@ -64,7 +64,8 @@ jobs:
 
       - name: build changed packages
         if: ${{ steps.yarn-lock.outcome == 'success' }}
-        run: yarn lerna -- run build --since origin/master
+        # Need to build all dependencies as well to be able to run tests later
+        run: yarn lerna -- run build --since origin/master --include-dependencies
 
       - name: build all packages
         if: ${{ steps.yarn-lock.outcome == 'failure' }}

packages/core/src/layout/Sidebar/Items.tsx

@@ -139,7 +139,7 @@ export const SidebarItem: FC<SidebarItemProps> = ({
       <NavLink
         className={clsx(classes.root, classes.closed)}
         activeClassName={classes.selected}
-        isActive={(match) => match && !disableSelected}
+        isActive={(match) => Boolean(match && !disableSelected)}
         exact
         to={to}
         onClick={onClick}
@@ -153,7 +153,7 @@ export const SidebarItem: FC<SidebarItemProps> = ({
     <NavLink
       className={clsx(classes.root, classes.open)}
       activeClassName={classes.selected}
-      isActive={(match) => match && !disableSelected}
+      isActive={(match) => Boolean(match && !disableSelected)}
       exact
       to={to}
       onClick={onClick}

packages/core/src/layout/Sidebar/Sidebar.stories.tsx

@@ -48,7 +48,7 @@ export const SampleSidebar = () => (
     {/* <SidebarLogo /> */}
     <SidebarSearchField onSearch={handleSearch} />
     <SidebarDivider />
-    <SidebarItem selected icon={HomeOutlinedIcon} to="#" text="Home" />
+    <SidebarItem icon={HomeOutlinedIcon} to="#" text="Home" />
     <SidebarItem icon={HomeOutlinedIcon} to="#" text="Plugins" />
     <SidebarItem icon={AddCircleOutlineIcon} to="#" text="Create..." />
     <SidebarDivider />

packages/core/src/layout/Sidebar/config.ts

@@ -40,7 +40,7 @@ export const sidebarConfig = {
 export const SIDEBAR_INTRO_LOCAL_STORAGE =
   '@backstage/core/sidebar-intro-dismissed';
 
-type SidebarContextType = {
+export type SidebarContextType = {
   isOpen: boolean;
 };