diff --git a/.github/workflows/frontend.yml b/.github/workflows/frontend.yml index 4ee0f5246b..d916141588 100644 --- a/.github/workflows/frontend.yml +++ b/.github/workflows/frontend.yml @@ -64,7 +64,8 @@ jobs: - name: build changed packages if: ${{ steps.yarn-lock.outcome == 'success' }} - run: yarn lerna -- run build --since origin/master + # Need to build all dependencies as well to be able to run tests later + run: yarn lerna -- run build --since origin/master --include-dependencies - name: build all packages if: ${{ steps.yarn-lock.outcome == 'failure' }} diff --git a/packages/core/src/layout/Sidebar/Items.tsx b/packages/core/src/layout/Sidebar/Items.tsx index 60132f0bc9..bd5faa5631 100644 --- a/packages/core/src/layout/Sidebar/Items.tsx +++ b/packages/core/src/layout/Sidebar/Items.tsx @@ -139,7 +139,7 @@ export const SidebarItem: FC = ({ match && !disableSelected} + isActive={(match) => Boolean(match && !disableSelected)} exact to={to} onClick={onClick} @@ -153,7 +153,7 @@ export const SidebarItem: FC = ({ match && !disableSelected} + isActive={(match) => Boolean(match && !disableSelected)} exact to={to} onClick={onClick} diff --git a/packages/core/src/layout/Sidebar/Sidebar.stories.tsx b/packages/core/src/layout/Sidebar/Sidebar.stories.tsx index fc0025caca..1b9ba5bbab 100644 --- a/packages/core/src/layout/Sidebar/Sidebar.stories.tsx +++ b/packages/core/src/layout/Sidebar/Sidebar.stories.tsx @@ -48,7 +48,7 @@ export const SampleSidebar = () => ( {/* */} - + diff --git a/packages/core/src/layout/Sidebar/config.ts b/packages/core/src/layout/Sidebar/config.ts index e101153bfb..8ea6cc94f9 100644 --- a/packages/core/src/layout/Sidebar/config.ts +++ b/packages/core/src/layout/Sidebar/config.ts @@ -40,7 +40,7 @@ export const sidebarConfig = { export const SIDEBAR_INTRO_LOCAL_STORAGE = '@backstage/core/sidebar-intro-dismissed'; -type SidebarContextType = { +export type SidebarContextType = { isOpen: boolean; };