Merge pull request #26586 from backstage/scaffolder/copy-improvements

[Scaffolder] copy improvements

.changeset/bright-pillows-confess.md

@@ -0,0 +1,5 @@
+---
+'@backstage/core-components': patch
+---
+
+Removed default title set to Unknown page on `ContentHeaderTitle` component to support usage of component without title prop.

.changeset/slimy-hornets-explode.md

@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-scaffolder': patch
+---
+
+Removed duplicated titles on Scaffolder `TemplateListPage` component

packages/core-components/src/layout/ContentHeader/ContentHeader.test.tsx

@@ -30,6 +30,13 @@ describe('<ContentHeader/>', () => {
     rendered.getByText('Title');
   });
 
+  it('should render without title', async () => {
+    const rendered = await renderInTestApp(
+      <ContentHeader>content</ContentHeader>,
+    );
+    rendered.getByText('content');
+  });
+
   it('should render with titleComponent', async () => {
     const title = 'Custom title';
     const titleComponent = <h1>{title}</h1>;

packages/core-components/src/layout/ContentHeader/ContentHeader.tsx

@@ -73,10 +73,7 @@ type ContentHeaderTitleProps = {
   className?: string;
 };
 
-const ContentHeaderTitle = ({
-  title = 'Unknown page',
-  className,
-}: ContentHeaderTitleProps) => (
+const ContentHeaderTitle = ({ title, className }: ContentHeaderTitleProps) => (
   <Typography
     variant="h4"
     component="h2"

plugins/scaffolder/api-report-alpha.md

@@ -230,7 +230,6 @@ export const scaffolderTranslationRef: TranslationRef<
     readonly 'templateListPage.pageTitle': 'Create a new component';
     readonly 'templateListPage.templateGroups.defaultTitle': 'Templates';
     readonly 'templateListPage.templateGroups.otherTitle': 'Other Templates';
-    readonly 'templateListPage.contentHeader.title': 'Available Templates';
     readonly 'templateListPage.contentHeader.registerExistingButtonTitle': 'Register Existing Component';
     readonly 'templateListPage.contentHeader.supportButtonTitle': 'Create new software components using standard templates. Different templates create different kinds of components (services, websites, documentation, ...).';
     readonly 'templateListPage.additionalLinksForEntity.viewTechDocsTitle': 'View TechDocs';

plugins/scaffolder/src/next/TemplateListPage/TemplateListPage.tsx

@@ -177,7 +177,7 @@ export const TemplateListPage = (props: TemplateListPageProps) => {
           <ScaffolderPageContextMenu {...scaffolderPageContextMenuProps} />
         </Header>
         <Content>
-          <ContentHeader title={t('templateListPage.contentHeader.title')}>
+          <ContentHeader>
             <RegisterExistingButton
               title={t(
                 'templateListPage.contentHeader.registerExistingButtonTitle',

plugins/scaffolder/src/translation.ts

@@ -261,7 +261,6 @@ export const scaffolderTranslationRef = createTranslationRef({
         otherTitle: 'Other Templates',
       },
       contentHeader: {
-        title: 'Available Templates',
         registerExistingButtonTitle: 'Register Existing Component',
         supportButtonTitle:
           'Create new software components using standard templates. Different templates create different kinds of components (services, websites, documentation, ...).',