diff --git a/.changeset/bright-pillows-confess.md b/.changeset/bright-pillows-confess.md new file mode 100644 index 0000000000..aa7210ffb8 --- /dev/null +++ b/.changeset/bright-pillows-confess.md @@ -0,0 +1,5 @@ +--- +'@backstage/core-components': patch +--- + +Removed default title set to Unknown page on `ContentHeaderTitle` component to support usage of component without title prop. diff --git a/.changeset/slimy-hornets-explode.md b/.changeset/slimy-hornets-explode.md new file mode 100644 index 0000000000..7f29061ab3 --- /dev/null +++ b/.changeset/slimy-hornets-explode.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-scaffolder': patch +--- + +Removed duplicated titles on Scaffolder `TemplateListPage` component diff --git a/packages/core-components/src/layout/ContentHeader/ContentHeader.test.tsx b/packages/core-components/src/layout/ContentHeader/ContentHeader.test.tsx index 37059766a8..5ae2efb806 100644 --- a/packages/core-components/src/layout/ContentHeader/ContentHeader.test.tsx +++ b/packages/core-components/src/layout/ContentHeader/ContentHeader.test.tsx @@ -30,6 +30,13 @@ describe('', () => { rendered.getByText('Title'); }); + it('should render without title', async () => { + const rendered = await renderInTestApp( + content, + ); + rendered.getByText('content'); + }); + it('should render with titleComponent', async () => { const title = 'Custom title'; const titleComponent =

{title}

; diff --git a/packages/core-components/src/layout/ContentHeader/ContentHeader.tsx b/packages/core-components/src/layout/ContentHeader/ContentHeader.tsx index 381919a170..e2a6e70620 100644 --- a/packages/core-components/src/layout/ContentHeader/ContentHeader.tsx +++ b/packages/core-components/src/layout/ContentHeader/ContentHeader.tsx @@ -73,10 +73,7 @@ type ContentHeaderTitleProps = { className?: string; }; -const ContentHeaderTitle = ({ - title = 'Unknown page', - className, -}: ContentHeaderTitleProps) => ( +const ContentHeaderTitle = ({ title, className }: ContentHeaderTitleProps) => ( { - +