addressed review comments

Signed-off-by: Eswaraiahsapram <esapram@redhat.com>
This commit is contained in:
Eswaraiahsapram
2025-11-04 17:51:18 +05:30
parent 992956e29f
commit 9b3cd87a04
4 changed files with 20 additions and 14 deletions
+2 -2
View File
@@ -43,8 +43,8 @@ export const catalogTranslationRef: TranslationRef<
readonly 'indexPage.title': '{{orgName}} Catalog';
readonly 'indexPage.createButtonTitle': 'Create';
readonly 'indexPage.supportButtonContent': 'All your software catalog entities';
readonly 'entityLayout.notFoundMessage': 'There is no {{kind}} with the requested';
readonly 'entityLayout.notFoundLinkText': 'kind, namespace, and name';
readonly 'entityPage.notFoundMessage': 'There is no {{kind}} with the requested {{link}}.';
readonly 'entityPage.notFoundLinkText': 'kind, namespace, and name';
readonly 'aboutCard.title': 'About';
readonly 'aboutCard.unknown': 'unknown';
readonly 'aboutCard.refreshButtonTitle': 'Schedule entity refresh';
@@ -180,11 +180,14 @@ export const EntityLayout = (props: EntityLayoutProps) => {
NotFoundComponent
) : (
<WarningPanel title={t('entityLabels.warningPanelTitle')}>
{t('entityLayout.notFoundMessage', { kind })}{' '}
<Link to="https://backstage.io/docs/features/software-catalog/references">
{t('entityLayout.notFoundLinkText')}
</Link>
.
{t('entityPage.notFoundMessage', {
kind,
link: (
<Link to="https://backstage.io/docs/features/software-catalog/references">
{t('entityPage.notFoundLinkText')}
</Link>
),
})}
</WarningPanel>
)}
</Content>
+2 -2
View File
@@ -25,8 +25,8 @@ export const catalogTranslationRef = createTranslationRef({
createButtonTitle: 'Create',
supportButtonContent: 'All your software catalog entities',
},
entityLayout: {
notFoundMessage: 'There is no {{kind}} with the requested',
entityPage: {
notFoundMessage: 'There is no {{kind}} with the requested {{link}}.',
notFoundLinkText: 'kind, namespace, and name',
},
aboutCard: {
@@ -389,11 +389,14 @@ export const EntityLayout = (props: EntityLayoutProps) => {
NotFoundComponent
) : (
<WarningPanel title={t('entityLabels.warningPanelTitle')}>
{t('entityLayout.notFoundMessage', { kind })}{' '}
<Link to="https://backstage.io/docs/features/software-catalog/references">
{t('entityLayout.notFoundLinkText')}
</Link>
.
{t('entityPage.notFoundMessage', {
kind,
link: (
<Link to="https://backstage.io/docs/features/software-catalog/references">
{t('entityPage.notFoundLinkText')}
</Link>
),
})}
</WarningPanel>
)}
</Content>