From 9b3cd87a047068d97603cd953081b5add11b4133 Mon Sep 17 00:00:00 2001 From: Eswaraiahsapram Date: Tue, 4 Nov 2025 17:51:18 +0530 Subject: [PATCH] addressed review comments Signed-off-by: Eswaraiahsapram --- plugins/catalog/report-alpha.api.md | 4 ++-- .../alpha/components/EntityLayout/EntityLayout.tsx | 13 ++++++++----- plugins/catalog/src/alpha/translation.ts | 4 ++-- .../src/components/EntityLayout/EntityLayout.tsx | 13 ++++++++----- 4 files changed, 20 insertions(+), 14 deletions(-) diff --git a/plugins/catalog/report-alpha.api.md b/plugins/catalog/report-alpha.api.md index 6dc22788c5..380ca2adb8 100644 --- a/plugins/catalog/report-alpha.api.md +++ b/plugins/catalog/report-alpha.api.md @@ -43,8 +43,8 @@ export const catalogTranslationRef: TranslationRef< readonly 'indexPage.title': '{{orgName}} Catalog'; readonly 'indexPage.createButtonTitle': 'Create'; readonly 'indexPage.supportButtonContent': 'All your software catalog entities'; - readonly 'entityLayout.notFoundMessage': 'There is no {{kind}} with the requested'; - readonly 'entityLayout.notFoundLinkText': 'kind, namespace, and name'; + readonly 'entityPage.notFoundMessage': 'There is no {{kind}} with the requested {{link}}.'; + readonly 'entityPage.notFoundLinkText': 'kind, namespace, and name'; readonly 'aboutCard.title': 'About'; readonly 'aboutCard.unknown': 'unknown'; readonly 'aboutCard.refreshButtonTitle': 'Schedule entity refresh'; diff --git a/plugins/catalog/src/alpha/components/EntityLayout/EntityLayout.tsx b/plugins/catalog/src/alpha/components/EntityLayout/EntityLayout.tsx index e881135a9a..ee6e2fc012 100644 --- a/plugins/catalog/src/alpha/components/EntityLayout/EntityLayout.tsx +++ b/plugins/catalog/src/alpha/components/EntityLayout/EntityLayout.tsx @@ -180,11 +180,14 @@ export const EntityLayout = (props: EntityLayoutProps) => { NotFoundComponent ) : ( - {t('entityLayout.notFoundMessage', { kind })}{' '} - - {t('entityLayout.notFoundLinkText')} - - . + {t('entityPage.notFoundMessage', { + kind, + link: ( + + {t('entityPage.notFoundLinkText')} + + ), + })} )} diff --git a/plugins/catalog/src/alpha/translation.ts b/plugins/catalog/src/alpha/translation.ts index 885caeb280..b0376466f6 100644 --- a/plugins/catalog/src/alpha/translation.ts +++ b/plugins/catalog/src/alpha/translation.ts @@ -25,8 +25,8 @@ export const catalogTranslationRef = createTranslationRef({ createButtonTitle: 'Create', supportButtonContent: 'All your software catalog entities', }, - entityLayout: { - notFoundMessage: 'There is no {{kind}} with the requested', + entityPage: { + notFoundMessage: 'There is no {{kind}} with the requested {{link}}.', notFoundLinkText: 'kind, namespace, and name', }, aboutCard: { diff --git a/plugins/catalog/src/components/EntityLayout/EntityLayout.tsx b/plugins/catalog/src/components/EntityLayout/EntityLayout.tsx index 07dc5d6d7a..5ee6a7f0f1 100644 --- a/plugins/catalog/src/components/EntityLayout/EntityLayout.tsx +++ b/plugins/catalog/src/components/EntityLayout/EntityLayout.tsx @@ -389,11 +389,14 @@ export const EntityLayout = (props: EntityLayoutProps) => { NotFoundComponent ) : ( - {t('entityLayout.notFoundMessage', { kind })}{' '} - - {t('entityLayout.notFoundLinkText')} - - . + {t('entityPage.notFoundMessage', { + kind, + link: ( + + {t('entityPage.notFoundLinkText')} + + ), + })} )}