paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 26 Packages Projects Releases Wiki Activity

Added baseURL per recomendation from @stefanalund

Browse Source
This commit is contained in:
ebarrios
2020-07-14 08:11:00 +02:00
parent 8b455197d7
commit 8fbe0d32f4
2 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/backend/package.json
+1 -1
View File
@@ -18,7 +18,6 @@
"migrate:create": "knex migrate:make -x ts"
},
"dependencies": {
"@backstage/plugin-proxy-backend": "^0.1.1-alpha.13",
"@backstage/backend-common": "^0.1.1-alpha.13",
"@backstage/catalog-model": "^0.1.1-alpha.13",
"@backstage/config": "^0.1.1-alpha.13",
@@ -26,6 +25,7 @@
"@backstage/plugin-auth-backend": "^0.1.1-alpha.13",
"@backstage/plugin-catalog-backend": "^0.1.1-alpha.13",
"@backstage/plugin-identity-backend": "^0.1.1-alpha.13",
"@backstage/plugin-proxy-backend": "^0.1.1-alpha.13",
"@backstage/plugin-rollbar-backend": "^0.1.1-alpha.13",
"@backstage/plugin-scaffolder-backend": "^0.1.1-alpha.13",
"@backstage/plugin-sentry-backend": "^0.1.1-alpha.13",
plugins/gcp-projects/src/api/GCPClient.ts
+7 -8
View File
@@ -17,11 +17,12 @@
import { GCPApi } from './GCPApi';
import { Project, Operation, Status } from './types';
const BaseURL =
'https://content-cloudresourcemanager.googleapis.com/v1/projects';
export class GCPClient implements GCPApi {
async listProjects({ token }: { token: string }): Promise<Project[]> {
const url = `https://content-cloudresourcemanager.googleapis.com/v1/projects`;
const response = await fetch(url, {
const response = await fetch(BaseURL, {
headers: new Headers({
Accept: '*/*',
Authorization: `Bearer ${token}`,
@@ -50,7 +51,7 @@ export class GCPClient implements GCPApi {
projectId: string,
token: Promise<string>,
): Promise<Project> {
const url = `https://content-cloudresourcemanager.googleapis.com/v1/projects/${projectId}`;
const url = `${BaseURL}/${projectId}`;
const response = await fetch(url, {
headers: new Headers({
Authorization: `Bearer ${await token}`,
@@ -59,7 +60,7 @@ export class GCPClient implements GCPApi {
const dataBlank: Project = {
name: 'Error',
projectNumber: `Response status is${response.status}`,
projectNumber: `Response status is ${response.status}`,
projectId: 'Error',
lifecycleState: 'error',
createTime: 'Error',
@@ -102,9 +103,7 @@ export class GCPClient implements GCPApi {
const body = JSON.stringify(newProject);
const url = `https://content-cloudresourcemanager.googleapis.com/v1/projects`;
const response = await fetch(url, {
const response = await fetch(BaseURL, {
headers: new Headers({
Accept: '*/*',
Authorization: `Bearer ${token}`,