From 8fbe0d32f4d2803f9105e3fb0af74ff1cbae9689 Mon Sep 17 00:00:00 2001
From: ebarrios <esteban.barrios@trivago.com>
Date: Tue, 14 Jul 2020 08:11:00 +0200
Subject: [PATCH] Added baseURL per recomendation from @stefanalund

---
 packages/backend/package.json             |  2 +-
 plugins/gcp-projects/src/api/GCPClient.ts | 15 +++++++--------
 2 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/packages/backend/package.json b/packages/backend/package.json
index 2844f17744..9e42f6c4cb 100644
--- a/packages/backend/package.json
+++ b/packages/backend/package.json
@@ -18,7 +18,6 @@
     "migrate:create": "knex migrate:make -x ts"
   },
   "dependencies": {
-    "@backstage/plugin-proxy-backend": "^0.1.1-alpha.13",
     "@backstage/backend-common": "^0.1.1-alpha.13",
     "@backstage/catalog-model": "^0.1.1-alpha.13",
     "@backstage/config": "^0.1.1-alpha.13",
@@ -26,6 +25,7 @@
     "@backstage/plugin-auth-backend": "^0.1.1-alpha.13",
     "@backstage/plugin-catalog-backend": "^0.1.1-alpha.13",
     "@backstage/plugin-identity-backend": "^0.1.1-alpha.13",
+    "@backstage/plugin-proxy-backend": "^0.1.1-alpha.13",
     "@backstage/plugin-rollbar-backend": "^0.1.1-alpha.13",
     "@backstage/plugin-scaffolder-backend": "^0.1.1-alpha.13",
     "@backstage/plugin-sentry-backend": "^0.1.1-alpha.13",
diff --git a/plugins/gcp-projects/src/api/GCPClient.ts b/plugins/gcp-projects/src/api/GCPClient.ts
index fd8b708377..dc4fe21132 100644
--- a/plugins/gcp-projects/src/api/GCPClient.ts
+++ b/plugins/gcp-projects/src/api/GCPClient.ts
@@ -17,11 +17,12 @@
 import { GCPApi } from './GCPApi';
 import { Project, Operation, Status } from './types';
 
+const BaseURL =
+  'https://content-cloudresourcemanager.googleapis.com/v1/projects';
+
 export class GCPClient implements GCPApi {
   async listProjects({ token }: { token: string }): Promise<Project[]> {
-    const url = `https://content-cloudresourcemanager.googleapis.com/v1/projects`;
-
-    const response = await fetch(url, {
+    const response = await fetch(BaseURL, {
       headers: new Headers({
         Accept: '*/*',
         Authorization: `Bearer ${token}`,
@@ -50,7 +51,7 @@ export class GCPClient implements GCPApi {
     projectId: string,
     token: Promise<string>,
   ): Promise<Project> {
-    const url = `https://content-cloudresourcemanager.googleapis.com/v1/projects/${projectId}`;
+    const url = `${BaseURL}/${projectId}`;
     const response = await fetch(url, {
       headers: new Headers({
         Authorization: `Bearer ${await token}`,
@@ -59,7 +60,7 @@ export class GCPClient implements GCPApi {
 
     const dataBlank: Project = {
       name: 'Error',
-      projectNumber: `Response status is${response.status}`,
+      projectNumber: `Response status is ${response.status}`,
       projectId: 'Error',
       lifecycleState: 'error',
       createTime: 'Error',
@@ -102,9 +103,7 @@ export class GCPClient implements GCPApi {
 
     const body = JSON.stringify(newProject);
 
-    const url = `https://content-cloudresourcemanager.googleapis.com/v1/projects`;
-
-    const response = await fetch(url, {
+    const response = await fetch(BaseURL, {
       headers: new Headers({
         Accept: '*/*',
         Authorization: `Bearer ${token}`,