feat: add logging when skipping checks

Signed-off-by: Jacob Wejendorp <jwe@tradeshift.com>
2021-12-17 11:59:29 +01:00
parent 91c353da3a
commit 8814c893e3
1 changed files with 9 additions and 1 deletions
@@ -90,10 +90,18 @@ export class JsonRulesEngineFactChecker
      rule.name = techInsightCheck.id;
      // Only run checks that have all the facts available:
      const hasAllFacts = techInsightCheck.factIds.every(
-        factId => !!facts[factId],
+        factId => facts[factId],
      );
      if (hasAllFacts) {
        engine.addRule({ ...techInsightCheck.rule, event: noopEvent });
+      } else {
+        this.logger.warn(
+          `Skipping ${
+            rule.name
+          } due to missing facts: ${techInsightCheck.factIds
+            .filter(factId => !facts[factId])
+            .join(', ')}`,
+        );
      }
    });
    const factValues = Object.values(facts).reduce(