From 8814c893e3bd3efde71a3efac32c844d661f7472 Mon Sep 17 00:00:00 2001
From: Jacob Wejendorp <jwe@tradeshift.com>
Date: Fri, 17 Dec 2021 11:59:29 +0100
Subject: [PATCH] feat: add logging when skipping checks

Signed-off-by: Jacob Wejendorp <jwe@tradeshift.com>
---
 .../src/service/JsonRulesEngineFactChecker.ts          | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/plugins/tech-insights-backend-module-jsonfc/src/service/JsonRulesEngineFactChecker.ts b/plugins/tech-insights-backend-module-jsonfc/src/service/JsonRulesEngineFactChecker.ts
index 640ad51113..2623a5c2ee 100644
--- a/plugins/tech-insights-backend-module-jsonfc/src/service/JsonRulesEngineFactChecker.ts
+++ b/plugins/tech-insights-backend-module-jsonfc/src/service/JsonRulesEngineFactChecker.ts
@@ -90,10 +90,18 @@ export class JsonRulesEngineFactChecker
       rule.name = techInsightCheck.id;
       // Only run checks that have all the facts available:
       const hasAllFacts = techInsightCheck.factIds.every(
-        factId => !!facts[factId],
+        factId => facts[factId],
       );
       if (hasAllFacts) {
         engine.addRule({ ...techInsightCheck.rule, event: noopEvent });
+      } else {
+        this.logger.warn(
+          `Skipping ${
+            rule.name
+          } due to missing facts: ${techInsightCheck.factIds
+            .filter(factId => !facts[factId])
+            .join(', ')}`,
+        );
       }
     });
     const factValues = Object.values(facts).reduce(