Address review feedback:
- Scaffolder icon instead of copy icon - Examples of ISO 8601 duration strings Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
This commit is contained in:
@@ -741,7 +741,8 @@ potentially search and group templates by these tags.
|
||||
### `metadata.annotations.[backstage.io/time-saved]` [optional]
|
||||
|
||||
An ISO 8601 duration representing the approximate amount of time saved when
|
||||
someone uses this template.
|
||||
someone uses this template (e.g. `PT8H` to mean "8 hours saved" or `PT15M` to
|
||||
mean "15 minutes saved").
|
||||
|
||||
Can be used in combination with the `backstage.io/source-template` annotation,
|
||||
or analytics data, to calculate how much time has been saved through the use
|
||||
|
||||
@@ -326,10 +326,10 @@ describe('<AboutCard />', () => {
|
||||
);
|
||||
|
||||
await waitFor(() => {
|
||||
const editLink = screen
|
||||
const createSimilarLink = screen
|
||||
.getByTitle('Create something similar')
|
||||
.closest('a');
|
||||
expect(editLink).toHaveAttribute(
|
||||
expect(createSimilarLink).toHaveAttribute(
|
||||
'href',
|
||||
'/create/templates/default/foo-template',
|
||||
);
|
||||
|
||||
@@ -27,6 +27,7 @@ import Divider from '@material-ui/core/Divider';
|
||||
import IconButton from '@material-ui/core/IconButton';
|
||||
import { makeStyles } from '@material-ui/core/styles';
|
||||
import {
|
||||
AppIcon,
|
||||
HeaderIconLinkRow,
|
||||
IconLinkVerticalProps,
|
||||
InfoCardVariants,
|
||||
@@ -54,7 +55,6 @@ import { createFromTemplateRouteRef, viewTechDocRouteRef } from '../../routes';
|
||||
import { AboutContent } from './AboutContent';
|
||||
import CachedIcon from '@material-ui/icons/Cached';
|
||||
import CreateComponentIcon from '@material-ui/icons/AddCircleOutline';
|
||||
import CopyIcon from '@material-ui/icons/FileCopy';
|
||||
import DocsIcon from '@material-ui/icons/Description';
|
||||
import EditIcon from '@material-ui/icons/Edit';
|
||||
import { isTemplateEntityV1beta3 } from '@backstage/plugin-scaffolder-common';
|
||||
@@ -248,7 +248,7 @@ export function AboutCard(props: AboutCardProps) {
|
||||
templateName: sourceTemplateRef.name,
|
||||
})}
|
||||
>
|
||||
<CopyIcon />
|
||||
<AppIcon id="scaffolder" />
|
||||
</IconButton>
|
||||
)}
|
||||
</>
|
||||
|
||||
Reference in New Issue
Block a user