From 7a2c9032c768f2ce317db9d32fdc1412f77d8147 Mon Sep 17 00:00:00 2001
From: Eric Peterson <ericpeterson@spotify.com>
Date: Tue, 2 Apr 2024 13:44:39 +0200
Subject: [PATCH] Address review feedback: - Scaffolder icon instead of copy
 icon - Examples of ISO 8601 duration strings

Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
---
 docs/features/software-catalog/descriptor-format.md         | 3 ++-
 plugins/catalog/src/components/AboutCard/AboutCard.test.tsx | 4 ++--
 plugins/catalog/src/components/AboutCard/AboutCard.tsx      | 4 ++--
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/docs/features/software-catalog/descriptor-format.md b/docs/features/software-catalog/descriptor-format.md
index afa296d2f9..038e94bec3 100644
--- a/docs/features/software-catalog/descriptor-format.md
+++ b/docs/features/software-catalog/descriptor-format.md
@@ -741,7 +741,8 @@ potentially search and group templates by these tags.
 ### `metadata.annotations.[backstage.io/time-saved]` [optional]
 
 An ISO 8601 duration representing the approximate amount of time saved when
-someone uses this template.
+someone uses this template (e.g. `PT8H` to mean "8 hours saved" or `PT15M` to
+mean "15 minutes saved").
 
 Can be used in combination with the `backstage.io/source-template` annotation,
 or analytics data, to calculate how much time has been saved through the use
diff --git a/plugins/catalog/src/components/AboutCard/AboutCard.test.tsx b/plugins/catalog/src/components/AboutCard/AboutCard.test.tsx
index 481d5b4f64..f90942dcd8 100644
--- a/plugins/catalog/src/components/AboutCard/AboutCard.test.tsx
+++ b/plugins/catalog/src/components/AboutCard/AboutCard.test.tsx
@@ -326,10 +326,10 @@ describe('<AboutCard />', () => {
     );
 
     await waitFor(() => {
-      const editLink = screen
+      const createSimilarLink = screen
         .getByTitle('Create something similar')
         .closest('a');
-      expect(editLink).toHaveAttribute(
+      expect(createSimilarLink).toHaveAttribute(
         'href',
         '/create/templates/default/foo-template',
       );
diff --git a/plugins/catalog/src/components/AboutCard/AboutCard.tsx b/plugins/catalog/src/components/AboutCard/AboutCard.tsx
index 7c26a567a1..a24a132bc4 100644
--- a/plugins/catalog/src/components/AboutCard/AboutCard.tsx
+++ b/plugins/catalog/src/components/AboutCard/AboutCard.tsx
@@ -27,6 +27,7 @@ import Divider from '@material-ui/core/Divider';
 import IconButton from '@material-ui/core/IconButton';
 import { makeStyles } from '@material-ui/core/styles';
 import {
+  AppIcon,
   HeaderIconLinkRow,
   IconLinkVerticalProps,
   InfoCardVariants,
@@ -54,7 +55,6 @@ import { createFromTemplateRouteRef, viewTechDocRouteRef } from '../../routes';
 import { AboutContent } from './AboutContent';
 import CachedIcon from '@material-ui/icons/Cached';
 import CreateComponentIcon from '@material-ui/icons/AddCircleOutline';
-import CopyIcon from '@material-ui/icons/FileCopy';
 import DocsIcon from '@material-ui/icons/Description';
 import EditIcon from '@material-ui/icons/Edit';
 import { isTemplateEntityV1beta3 } from '@backstage/plugin-scaffolder-common';
@@ -248,7 +248,7 @@ export function AboutCard(props: AboutCardProps) {
                   templateName: sourceTemplateRef.name,
                 })}
               >
-                <CopyIcon />
+                <AppIcon id="scaffolder" />
               </IconButton>
             )}
           </>