Merge pull request #4380 from adamdmharvey/welcome-clean

example-app: Remove welcome plugin registration & cleanup

docs/overview/stability-index.md

@@ -384,11 +384,3 @@ A frontend plugin that provides a page where the user can tweak various
 settings.
 
 Stability: `1`
-
-### `welcome` [GitHub](https://github.com/backstage/backstage/tree/master/plugins/welcome/)
-
-A plugin that can be used to welcome the user to Backstage.
-
-Stability: `0`. This used to be the start page for the example app, but has been
-replaced by the catalog plugin. It is still viewable at `/welcome` but may be
-removed.

docs/reference/createPlugin-feature-flags.md

@@ -14,7 +14,7 @@ Here's a code sample:
 import { createPlugin } from '@backstage/core';
 
 export default createPlugin({
-  id: 'welcome',
+  id: 'plugin-name',
   register({ featureFlags }) {
     featureFlags.register('enable-example-feature');
   },

packages/app/package.json

@@ -34,7 +34,6 @@
     "@backstage/plugin-tech-radar": "^0.3.4",
     "@backstage/plugin-techdocs": "^0.5.5",
     "@backstage/plugin-user-settings": "^0.2.5",
-    "@backstage/plugin-welcome": "^0.2.5",
     "@backstage/theme": "^0.2.3",
     "@material-ui/core": "^4.11.0",
     "@material-ui/icons": "^4.9.1",

packages/app/src/plugins.ts

@@ -13,7 +13,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-export { plugin as WelcomePlugin } from '@backstage/plugin-welcome';
 export { plugin as LighthousePlugin } from '@backstage/plugin-lighthouse';
 export { plugin as CatalogPlugin } from '@backstage/plugin-catalog';
 export { plugin as ScaffolderPlugin } from '@backstage/plugin-scaffolder';

plugins/user-settings/src/components/FeatureFlags/EmptyFlags.tsx

@@ -21,7 +21,7 @@ import { Button, Typography } from '@material-ui/core';
 const EXAMPLE = `import { createPlugin } from '@backstage/core';
 
 export default createPlugin({
-  id: 'welcome',
+  id: 'plugin-name',
   register({ router, featureFlags }) {
     featureFlags.register('enable-example-feature');
   },

plugins/welcome/README.md

@@ -1,5 +1,8 @@
 # Title
 
+> This plugin formerly provided the "homepage" of early alpha versions of Backstage.
+> It is no longer in active use and in most cases can be removed from your instance.
+
 Welcome to the welcome plugin!
 
 ## Sub-section 1