From 02414fe00bef4753375b029926d9361fdda3c14d Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Wed, 3 Feb 2021 15:34:31 -0500 Subject: [PATCH 1/5] Remove welcome plugin registration --- packages/app/package.json | 7 +++---- packages/app/src/plugins.ts | 1 - 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/app/package.json b/packages/app/package.json index 9de8299d93..848717f7af 100644 --- a/packages/app/package.json +++ b/packages/app/package.json @@ -9,8 +9,8 @@ "@backstage/core": "^0.5.0", "@backstage/plugin-api-docs": "^0.4.3", "@backstage/plugin-catalog": "^0.2.14", - "@backstage/plugin-catalog-react": "^0.0.1", "@backstage/plugin-catalog-import": "^0.3.6", + "@backstage/plugin-catalog-react": "^0.0.1", "@backstage/plugin-circleci": "^0.2.6", "@backstage/plugin-cloudbuild": "^0.2.7", "@backstage/plugin-cost-insights": "^0.7.0", @@ -19,22 +19,21 @@ "@backstage/plugin-github-actions": "^0.3.0", "@backstage/plugin-gitops-profiles": "^0.2.3", "@backstage/plugin-graphiql": "^0.2.6", - "@backstage/plugin-org": "^0.3.4", "@backstage/plugin-jenkins": "^0.3.6", "@backstage/plugin-kafka": "^0.2.0", "@backstage/plugin-kubernetes": "^0.3.7", "@backstage/plugin-lighthouse": "^0.2.8", "@backstage/plugin-newrelic": "^0.2.3", + "@backstage/plugin-org": "^0.3.4", "@backstage/plugin-pagerduty": "0.2.6", "@backstage/plugin-register-component": "^0.2.7", "@backstage/plugin-rollbar": "^0.2.8", "@backstage/plugin-scaffolder": "^0.4.1", - "@backstage/plugin-sentry": "^0.3.3", "@backstage/plugin-search": "^0.2.6", + "@backstage/plugin-sentry": "^0.3.3", "@backstage/plugin-tech-radar": "^0.3.3", "@backstage/plugin-techdocs": "^0.5.4", "@backstage/plugin-user-settings": "^0.2.4", - "@backstage/plugin-welcome": "^0.2.4", "@backstage/theme": "^0.2.2", "@material-ui/core": "^4.11.0", "@material-ui/icons": "^4.9.1", diff --git a/packages/app/src/plugins.ts b/packages/app/src/plugins.ts index 70dd56df0d..c62c0435a2 100644 --- a/packages/app/src/plugins.ts +++ b/packages/app/src/plugins.ts @@ -13,7 +13,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -export { plugin as WelcomePlugin } from '@backstage/plugin-welcome'; export { plugin as LighthousePlugin } from '@backstage/plugin-lighthouse'; export { plugin as CatalogPlugin } from '@backstage/plugin-catalog'; export { plugin as ScaffolderPlugin } from '@backstage/plugin-scaffolder'; From a19021a7c17b2acbc048ab9a05a3454daebab786 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Wed, 3 Feb 2021 15:39:24 -0500 Subject: [PATCH 2/5] Remove reference to the welcome plugin --- docs/overview/stability-index.md | 8 -------- 1 file changed, 8 deletions(-) diff --git a/docs/overview/stability-index.md b/docs/overview/stability-index.md index 3304913f87..4172e4d1b7 100644 --- a/docs/overview/stability-index.md +++ b/docs/overview/stability-index.md @@ -384,11 +384,3 @@ A frontend plugin that provides a page where the user can tweak various settings. Stability: `1` - -### `welcome` [GitHub](https://github.com/backstage/backstage/tree/master/plugins/welcome/) - -A plugin that can be used to welcome the user to Backstage. - -Stability: `0`. This used to be the start page for the example app, but has been -replaced by the catalog plugin. It is still viewable at `/welcome` but may be -removed. From 98da973e1e8be8f77f351532c6bd27e2d27acd61 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Wed, 3 Feb 2021 15:40:13 -0500 Subject: [PATCH 3/5] Use different example name --- docs/reference/createPlugin-feature-flags.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/reference/createPlugin-feature-flags.md b/docs/reference/createPlugin-feature-flags.md index 622c085291..5bfb4fe096 100644 --- a/docs/reference/createPlugin-feature-flags.md +++ b/docs/reference/createPlugin-feature-flags.md @@ -14,7 +14,7 @@ Here's a code sample: import { createPlugin } from '@backstage/core'; export default createPlugin({ - id: 'welcome', + id: 'plugin-name', register({ featureFlags }) { featureFlags.register('enable-example-feature'); }, From 3d3f890d01bc2c84183dd670e2af6568e49f6ce0 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Wed, 3 Feb 2021 15:42:20 -0500 Subject: [PATCH 4/5] Clarify deprecation --- plugins/welcome/README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugins/welcome/README.md b/plugins/welcome/README.md index f0211c248a..c40a760c7c 100644 --- a/plugins/welcome/README.md +++ b/plugins/welcome/README.md @@ -1,5 +1,8 @@ # Title +> This plugin formerly provided the "homepage" of early alpha versions of Backstage. +> It is no longer in active use and in most cases can be removed from your instance. + Welcome to the welcome plugin! ## Sub-section 1 From 4f397bcbbc40c7d755faefb38818f6a854018fe6 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Wed, 3 Feb 2021 15:42:32 -0500 Subject: [PATCH 5/5] Use different example name --- .../user-settings/src/components/FeatureFlags/EmptyFlags.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/user-settings/src/components/FeatureFlags/EmptyFlags.tsx b/plugins/user-settings/src/components/FeatureFlags/EmptyFlags.tsx index de6f4703e0..985a67189b 100644 --- a/plugins/user-settings/src/components/FeatureFlags/EmptyFlags.tsx +++ b/plugins/user-settings/src/components/FeatureFlags/EmptyFlags.tsx @@ -21,7 +21,7 @@ import { Button, Typography } from '@material-ui/core'; const EXAMPLE = `import { createPlugin } from '@backstage/core'; export default createPlugin({ - id: 'welcome', + id: 'plugin-name', register({ router, featureFlags }) { featureFlags.register('enable-example-feature'); },