use set to look for existing feature flags

Signed-off-by: Kurt King <kurtaking@gmail.com> Signed-off-by: Kurt King <kurt.king@procore.com>
2022-11-29 14:00:54 -06:00
parent 43244e8889
commit 77b0e42982
1 changed files with 2 additions and 3 deletions
@@ -311,11 +311,10 @@ export class AppManager implements BackstageApp {
          // Go through the featureFlags returned from the traversal and
          // register those now the configApi has been loaded
          const registeredFlags = featureFlagsApi.getRegisteredFlags();
+          const flagNames = new Set(registeredFlags.map(f => f.name));
          for (const name of featureFlags) {
            // Prevents adding duplicate feature flags
-            if (!registeredFlags.some((featureFlag) => {
-              return featureFlag.name === name
-            })) {
+            if (!flagNames.has(name)) {
              featureFlagsApi.registerFlag({ name, pluginId: '' });
            }
          }