From 77b0e42982a59a85f499c200c89833496aa5c4a9 Mon Sep 17 00:00:00 2001 From: Kurt King Date: Tue, 29 Nov 2022 14:00:54 -0600 Subject: [PATCH] use set to look for existing feature flags Signed-off-by: Kurt King Signed-off-by: Kurt King --- packages/core-app-api/src/app/AppManager.tsx | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/core-app-api/src/app/AppManager.tsx b/packages/core-app-api/src/app/AppManager.tsx index 70d7bc5434..8c2e09c903 100644 --- a/packages/core-app-api/src/app/AppManager.tsx +++ b/packages/core-app-api/src/app/AppManager.tsx @@ -311,11 +311,10 @@ export class AppManager implements BackstageApp { // Go through the featureFlags returned from the traversal and // register those now the configApi has been loaded const registeredFlags = featureFlagsApi.getRegisteredFlags(); + const flagNames = new Set(registeredFlags.map(f => f.name)); for (const name of featureFlags) { // Prevents adding duplicate feature flags - if (!registeredFlags.some((featureFlag) => { - return featureFlag.name === name - })) { + if (!flagNames.has(name)) { featureFlagsApi.registerFlag({ name, pluginId: '' }); } }