Fix persistance

plugins/circleci/src/pages/SettingsPage/SettingsPage.tsx

@@ -71,7 +71,7 @@ export const SettingsPage = () => {
                     name="circleci-token"
                     label="Token"
                     value={token}
-                    onChange={(e) => setToken(e.target.value)}
+                    onChange={e => setToken(e.target.value)}
                   />
                 </ListItem>
                 <ListItem>
@@ -79,7 +79,7 @@ export const SettingsPage = () => {
                     name="circleci-owner"
                     label="Owner"
                     value={owner}
-                    onChange={(e) => setOwner(e.target.value)}
+                    onChange={e => setOwner(e.target.value)}
                   />
                 </ListItem>
                 <ListItem>
@@ -87,7 +87,7 @@ export const SettingsPage = () => {
                     name="circleci-repo"
                     label="Repo"
                     value={repo}
-                    onChange={(e) => setRepo(e.target.value)}
+                    onChange={e => setRepo(e.target.value)}
                   />
                 </ListItem>
                 <ListItem>
@@ -96,7 +96,7 @@ export const SettingsPage = () => {
                     variant="outlined"
                     color="primary"
                     onClick={() =>
-                      dispatch.settings.setCredentialsEffect({
+                      dispatch.settings.setCredentials({
                         owner,
                         repo,
                         token,

plugins/circleci/src/state/models/settings.ts

@@ -22,7 +22,7 @@ export const settings = {
     },
   },
   effects: (dispatch: Dispatch) => ({
-    setCredentialsEffect(
+    setCredentials(
       {
         credentials,
         doPersist = true,
@@ -32,7 +32,7 @@ export const settings = {
       const newState = { ...state.settings, ...credentials };
 
       if (doPersist) dispatch.settings.persist(newState);
-      dispatch.settings.setCredentials(newState);
+      // dispatch.settings.setCredentials(newState);
     },
     persist(payload: RootModel) {
       sessionStorage.setItem(STORAGE_KEY, JSON.stringify(payload));
@@ -47,13 +47,14 @@ export const settings = {
         if (
           stateFromStorage &&
           Object.keys(stateFromStorage).some(
-            (k) => (state as any).settings[k] !== stateFromStorage[k],
+            k => (state as any).settings[k] !== stateFromStorage[k],
           )
         )
-          dispatch.settings.setCredentialsEffect({
-            credentials: stateFromStorage,
-            doPersist: false,
-          });
+          // dispatch.settings.setCredentialsEffect({
+          //   credentials: stateFromStorage,
+          //   doPersist: false,
+          // });
+          dispatch.settings.setCredentials(stateFromStorage);
       } catch (e) {
         console.log(e);
       }