diff --git a/plugins/circleci/src/pages/SettingsPage/SettingsPage.tsx b/plugins/circleci/src/pages/SettingsPage/SettingsPage.tsx index 68649511f2..3d9e14f6c6 100644 --- a/plugins/circleci/src/pages/SettingsPage/SettingsPage.tsx +++ b/plugins/circleci/src/pages/SettingsPage/SettingsPage.tsx @@ -71,7 +71,7 @@ export const SettingsPage = () => { name="circleci-token" label="Token" value={token} - onChange={(e) => setToken(e.target.value)} + onChange={e => setToken(e.target.value)} /> @@ -79,7 +79,7 @@ export const SettingsPage = () => { name="circleci-owner" label="Owner" value={owner} - onChange={(e) => setOwner(e.target.value)} + onChange={e => setOwner(e.target.value)} /> @@ -87,7 +87,7 @@ export const SettingsPage = () => { name="circleci-repo" label="Repo" value={repo} - onChange={(e) => setRepo(e.target.value)} + onChange={e => setRepo(e.target.value)} /> @@ -96,7 +96,7 @@ export const SettingsPage = () => { variant="outlined" color="primary" onClick={() => - dispatch.settings.setCredentialsEffect({ + dispatch.settings.setCredentials({ owner, repo, token, diff --git a/plugins/circleci/src/state/models/settings.ts b/plugins/circleci/src/state/models/settings.ts index d92a5f8fa1..992fd28243 100644 --- a/plugins/circleci/src/state/models/settings.ts +++ b/plugins/circleci/src/state/models/settings.ts @@ -22,7 +22,7 @@ export const settings = { }, }, effects: (dispatch: Dispatch) => ({ - setCredentialsEffect( + setCredentials( { credentials, doPersist = true, @@ -32,7 +32,7 @@ export const settings = { const newState = { ...state.settings, ...credentials }; if (doPersist) dispatch.settings.persist(newState); - dispatch.settings.setCredentials(newState); + // dispatch.settings.setCredentials(newState); }, persist(payload: RootModel) { sessionStorage.setItem(STORAGE_KEY, JSON.stringify(payload)); @@ -47,13 +47,14 @@ export const settings = { if ( stateFromStorage && Object.keys(stateFromStorage).some( - (k) => (state as any).settings[k] !== stateFromStorage[k], + k => (state as any).settings[k] !== stateFromStorage[k], ) ) - dispatch.settings.setCredentialsEffect({ - credentials: stateFromStorage, - doPersist: false, - }); + // dispatch.settings.setCredentialsEffect({ + // credentials: stateFromStorage, + // doPersist: false, + // }); + dispatch.settings.setCredentials(stateFromStorage); } catch (e) { console.log(e); }