paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 25 Packages Projects Releases Wiki Activity

fix: address review feedback

Browse Source 
- Await both tabs before asserting order in tab ordering tests
- Use findByText for icon assertions in context menu tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Fredrik Adelöw <freben@spotify.com>
This commit is contained in:
Fredrik Adelöw
2026-05-13 12:00:48 +02:00
parent 4eb547fa12
commit 6fd90ee0a7
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/catalog/src/alpha/pages.test.tsx
+8 -2
View File
@@ -387,6 +387,9 @@ describe('Entity page', () => {
await expect(
screen.findByRole('tab', { name: /Documentation/ }),
).resolves.toBeInTheDocument();
await expect(
screen.findByRole('tab', { name: /Overview/ }),
).resolves.toBeInTheDocument();
const tabs = screen.getAllByRole('tab');
expect(tabs).toHaveLength(2);
expect(tabs[0]).toHaveTextContent('Documentation');
@@ -605,6 +608,9 @@ describe('Entity page', () => {
await expect(
screen.findByRole('tab', { name: /Overview/ }),
).resolves.toBeInTheDocument();
await expect(
screen.findByRole('tab', { name: /Documentation/ }),
).resolves.toBeInTheDocument();
const tabs = screen.getAllByRole('tab');
expect(tabs).toHaveLength(2);
expect(tabs[0]).toHaveTextContent('Overview');
@@ -738,7 +744,7 @@ describe('Entity page', () => {
await userEvent.click(await screen.findByTestId('menu-button'));
const title = await screen.findByText('Test Title');
expect(screen.getByText('Test Icon')).toBeInTheDocument();
await expect(screen.findByText('Test Icon')).resolves.toBeInTheDocument();
const anchor = title.closest('a');
expect(anchor).toHaveAttribute('href', '/somewhere');
expect(anchor).toHaveAttribute('aria-disabled', disabled.toString());
@@ -801,7 +807,7 @@ describe('Entity page', () => {
screen.findByText('Test Title'),
).resolves.toBeInTheDocument();
expect(screen.getByText('Test Icon')).toBeInTheDocument();
await expect(screen.findByText('Test Icon')).resolves.toBeInTheDocument();
const listItem = screen.getByText('Test Title').closest('li');
expect(listItem).toHaveAttribute('aria-disabled', disabled.toString());
if (!disabled) {