From 6fd90ee0a7378cd34827f08211ee35d464f0b6de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= Date: Wed, 13 May 2026 12:00:48 +0200 Subject: [PATCH] fix: address review feedback MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Await both tabs before asserting order in tab ordering tests - Use findByText for icon assertions in context menu tests Co-Authored-By: Claude Opus 4.6 (1M context) Signed-off-by: Fredrik Adelöw --- plugins/catalog/src/alpha/pages.test.tsx | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/plugins/catalog/src/alpha/pages.test.tsx b/plugins/catalog/src/alpha/pages.test.tsx index 0ec8d0ef9b..239f286515 100644 --- a/plugins/catalog/src/alpha/pages.test.tsx +++ b/plugins/catalog/src/alpha/pages.test.tsx @@ -387,6 +387,9 @@ describe('Entity page', () => { await expect( screen.findByRole('tab', { name: /Documentation/ }), ).resolves.toBeInTheDocument(); + await expect( + screen.findByRole('tab', { name: /Overview/ }), + ).resolves.toBeInTheDocument(); const tabs = screen.getAllByRole('tab'); expect(tabs).toHaveLength(2); expect(tabs[0]).toHaveTextContent('Documentation'); @@ -605,6 +608,9 @@ describe('Entity page', () => { await expect( screen.findByRole('tab', { name: /Overview/ }), ).resolves.toBeInTheDocument(); + await expect( + screen.findByRole('tab', { name: /Documentation/ }), + ).resolves.toBeInTheDocument(); const tabs = screen.getAllByRole('tab'); expect(tabs).toHaveLength(2); expect(tabs[0]).toHaveTextContent('Overview'); @@ -738,7 +744,7 @@ describe('Entity page', () => { await userEvent.click(await screen.findByTestId('menu-button')); const title = await screen.findByText('Test Title'); - expect(screen.getByText('Test Icon')).toBeInTheDocument(); + await expect(screen.findByText('Test Icon')).resolves.toBeInTheDocument(); const anchor = title.closest('a'); expect(anchor).toHaveAttribute('href', '/somewhere'); expect(anchor).toHaveAttribute('aria-disabled', disabled.toString()); @@ -801,7 +807,7 @@ describe('Entity page', () => { screen.findByText('Test Title'), ).resolves.toBeInTheDocument(); - expect(screen.getByText('Test Icon')).toBeInTheDocument(); + await expect(screen.findByText('Test Icon')).resolves.toBeInTheDocument(); const listItem = screen.getByText('Test Title').closest('li'); expect(listItem).toHaveAttribute('aria-disabled', disabled.toString()); if (!disabled) {