Merge pull request #31772 from elaine-mattos/fix/frontend-plugin-template-dependencies
Fix frontend plugin template dependencies
This commit is contained in:
@@ -0,0 +1,16 @@
|
||||
---
|
||||
'@backstage/cli': patch
|
||||
---
|
||||
|
||||
Add missing peer/dev dependencies to the frontend plugin template.
|
||||
|
||||
`react-dom` was not declared as a peer dependency, causing module resolution
|
||||
errors when generating plugins outside a Backstage monorepo. This adds
|
||||
`react-dom` to `peerDependencies` (for consuming apps) and `devDependencies`
|
||||
(for local development). `react-router-dom` is also added to `peerDependencies` (for consuming apps) and `devDependencies`
|
||||
to support routing during plugin development.
|
||||
|
||||
Fixes:
|
||||
|
||||
- Module not found: Can't resolve 'react-dom'
|
||||
- Module not found: Can't resolve 'react-router-dom'
|
||||
@@ -31,7 +31,9 @@
|
||||
"react-use": "{{versionQuery 'react-use' '17.2.4'}}"
|
||||
},
|
||||
"peerDependencies": {
|
||||
"react": "{{versionQuery 'react' '^16.13.1 || ^17.0.0 || ^18.0.0'}}"
|
||||
"react": "{{versionQuery 'react' '^16.13.1 || ^17.0.0 || ^18.0.0'}}",
|
||||
"react-dom": "{{versionQuery 'react-dom' '^16.13.1 || ^17.0.0 || ^18.0.0'}}",
|
||||
"react-router-dom": "{{versionQuery 'react-router-dom' '^6.0.0'}}"
|
||||
},
|
||||
"devDependencies": {
|
||||
"@backstage/cli": "{{versionQuery '@backstage/cli'}}",
|
||||
@@ -42,7 +44,9 @@
|
||||
"@testing-library/react": "{{versionQuery '@testing-library/react' '14.0.0'}}",
|
||||
"@testing-library/user-event": "{{versionQuery '@testing-library/user-event' '14.0.0'}}",
|
||||
"msw": "{{versionQuery 'msw' '1.0.0'}}",
|
||||
"react": "{{versionQuery 'react' '^16.13.1 || ^17.0.0 || ^18.0.0'}}"
|
||||
"react": "{{versionQuery 'react' '^16.13.1 || ^17.0.0 || ^18.0.0'}}",
|
||||
"react-dom": "{{versionQuery 'react-dom' '^16.13.1 || ^17.0.0 || ^18.0.0'}}",
|
||||
"react-router-dom": "{{versionQuery 'react-router-dom' '^6.0.0'}}"
|
||||
},
|
||||
"files": [
|
||||
"dist"
|
||||
|
||||
Reference in New Issue
Block a user