From 3acce8c96973dfda46597cfd2209233e58b9d919 Mon Sep 17 00:00:00 2001 From: ElaineDeMattosSilvaB Date: Sat, 15 Nov 2025 07:56:41 +0100 Subject: [PATCH 1/4] fix(cli): add react-dom to peer and dev dependencies in frontend plugin template Signed-off-by: ElaineDeMattosSilvaB --- packages/cli/templates/frontend-plugin/package.json.hbs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/cli/templates/frontend-plugin/package.json.hbs b/packages/cli/templates/frontend-plugin/package.json.hbs index 1ee8231228..fe74e0e19c 100644 --- a/packages/cli/templates/frontend-plugin/package.json.hbs +++ b/packages/cli/templates/frontend-plugin/package.json.hbs @@ -31,7 +31,8 @@ "react-use": "{{versionQuery 'react-use' '17.2.4'}}" }, "peerDependencies": { - "react": "{{versionQuery 'react' '^16.13.1 || ^17.0.0 || ^18.0.0'}}" + "react": "{{versionQuery 'react' '^16.13.1 || ^17.0.0 || ^18.0.0'}}", + "react-dom": "{{versionQuery 'react-dom' '^16.13.1 || ^17.0.0 || ^18.0.0'}}" }, "devDependencies": { "@backstage/cli": "{{versionQuery '@backstage/cli'}}", @@ -42,7 +43,9 @@ "@testing-library/react": "{{versionQuery '@testing-library/react' '14.0.0'}}", "@testing-library/user-event": "{{versionQuery '@testing-library/user-event' '14.0.0'}}", "msw": "{{versionQuery 'msw' '1.0.0'}}", - "react": "{{versionQuery 'react' '^16.13.1 || ^17.0.0 || ^18.0.0'}}" + "react": "{{versionQuery 'react' '^16.13.1 || ^17.0.0 || ^18.0.0'}}", + "react-dom": "{{versionQuery 'react-dom' '^16.13.1 || ^17.0.0 || ^18.0.0'}}", + "react-router-dom": "{{versionQuery 'react-router-dom' '^6.0.0'}}" }, "files": [ "dist" From e7db2904fdeced469b245ef546eb28093d431bec Mon Sep 17 00:00:00 2001 From: ElaineDeMattosSilvaB Date: Sat, 15 Nov 2025 08:01:40 +0100 Subject: [PATCH 2/4] fix: add changeset Signed-off-by: ElaineDeMattosSilvaB --- .changeset/early-carpets-rush.md | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 .changeset/early-carpets-rush.md diff --git a/.changeset/early-carpets-rush.md b/.changeset/early-carpets-rush.md new file mode 100644 index 0000000000..a0851aef93 --- /dev/null +++ b/.changeset/early-carpets-rush.md @@ -0,0 +1,16 @@ +--- +'@backstage/cli': patch +--- + +Add missing peer/dev dependencies to the frontend plugin template. + +`react-dom` was not declared as a peer dependency, causing module resolution +errors when generating plugins outside a Backstage monorepo. This adds +`react-dom` to `peerDependencies` (for consuming apps) and `devDependencies` +(for local development). `react-router-dom` is also added to `devDependencies` +to support routing during plugin development. + +Fixes: + +- Module not found: Can't resolve 'react-dom' +- Module not found: Can't resolve 'react-router-dom' From 35002fb2618395b5c08b10717f1a9c7e8e47a00e Mon Sep 17 00:00:00 2001 From: ElaineDeMattosSilvaB Date: Wed, 26 Nov 2025 13:15:09 +0100 Subject: [PATCH 3/4] fix: add react-router-dom to peer deps Signed-off-by: ElaineDeMattosSilvaB --- packages/cli/templates/frontend-plugin/package.json.hbs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/cli/templates/frontend-plugin/package.json.hbs b/packages/cli/templates/frontend-plugin/package.json.hbs index fe74e0e19c..9499d11b18 100644 --- a/packages/cli/templates/frontend-plugin/package.json.hbs +++ b/packages/cli/templates/frontend-plugin/package.json.hbs @@ -32,7 +32,8 @@ }, "peerDependencies": { "react": "{{versionQuery 'react' '^16.13.1 || ^17.0.0 || ^18.0.0'}}", - "react-dom": "{{versionQuery 'react-dom' '^16.13.1 || ^17.0.0 || ^18.0.0'}}" + "react-dom": "{{versionQuery 'react-dom' '^16.13.1 || ^17.0.0 || ^18.0.0'}}", + "react-router-dom": "{{versionQuery 'react-router-dom' '^6.0.0'}}" }, "devDependencies": { "@backstage/cli": "{{versionQuery '@backstage/cli'}}", From 65e412350bd6563ac8f34d1934d4266ab1da22b5 Mon Sep 17 00:00:00 2001 From: Elaine Mattos Date: Thu, 27 Nov 2025 14:42:54 +0100 Subject: [PATCH 4/4] Update .changeset/early-carpets-rush.md Co-authored-by: Aramis Sennyey <159921952+aramissennyeydd@users.noreply.github.com> Signed-off-by: Elaine Mattos --- .changeset/early-carpets-rush.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/early-carpets-rush.md b/.changeset/early-carpets-rush.md index a0851aef93..dbdc5410c9 100644 --- a/.changeset/early-carpets-rush.md +++ b/.changeset/early-carpets-rush.md @@ -7,7 +7,7 @@ Add missing peer/dev dependencies to the frontend plugin template. `react-dom` was not declared as a peer dependency, causing module resolution errors when generating plugins outside a Backstage monorepo. This adds `react-dom` to `peerDependencies` (for consuming apps) and `devDependencies` -(for local development). `react-router-dom` is also added to `devDependencies` +(for local development). `react-router-dom` is also added to `peerDependencies` (for consuming apps) and `devDependencies` to support routing during plugin development. Fixes: