paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 41 Packages Projects Releases Wiki Activity

Remove the star and unstar method from DefaultStarredEntitiesApi

Browse Source 
Signed-off-by: Dominik Henneke <dominik.henneke@sda-se.com>
This commit is contained in:
Dominik Henneke
2021-10-12 10:16:30 +02:00
parent 8f55fb815b
commit 56f0ef983e
3 changed files with 2 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/catalog-react/api-report.md
-4
View File
@@ -141,13 +141,9 @@ export class DefaultStarredEntitiesApi implements StarredEntitiesApi {
// (undocumented)
isStarred(entity: Entity): boolean;
// (undocumented)
star(entity: Entity): Promise<void>;
// (undocumented)
starredEntitie$(): Observable<StarredEntitiesApiObservable>;
// (undocumented)
toggleStarred(entity: Entity): Promise<void>;
// (undocumented)
unstar(entity: Entity): Promise<void>;
}
// Warning: (ae-forgotten-export) The symbol "EntityLoadingStatus" needs to be exported by the entry point index.d.ts
plugins/catalog-react/src/apis/StarredEntitiesApi/DefaultStarredEntitiesApi.test.ts
-42
View File
@@ -63,48 +63,6 @@ describe('DefaultStarredEntitiesApi', () => {
});
});
describe('star', () => {
it('should star unstarred entity', async () => {
expect(starredEntitiesApi.isStarred(mockEntity)).toBe(false);
await starredEntitiesApi.star(mockEntity);
expect(starredEntitiesApi.isStarred(mockEntity)).toBe(true);
});
it('should keep starred entity', async () => {
const bucket = mockStorage.forBucket('settings');
await bucket.set('starredEntities', ['entity:Component:default:mock']);
expect(starredEntitiesApi.isStarred(mockEntity)).toBe(true);
await starredEntitiesApi.star(mockEntity);
expect(starredEntitiesApi.isStarred(mockEntity)).toBe(true);
});
});
describe('unstar', () => {
it('should unstar starred entity', async () => {
const bucket = mockStorage.forBucket('settings');
await bucket.set('starredEntities', ['entity:Component:default:mock']);
expect(starredEntitiesApi.isStarred(mockEntity)).toBe(true);
await starredEntitiesApi.unstar(mockEntity);
expect(starredEntitiesApi.isStarred(mockEntity)).toBe(false);
});
it('should keep unstarred entity', async () => {
expect(starredEntitiesApi.isStarred(mockEntity)).toBe(false);
await starredEntitiesApi.unstar(mockEntity);
expect(starredEntitiesApi.isStarred(mockEntity)).toBe(false);
});
});
describe('starredEntities$', () => {
const handler = jest.fn();
plugins/catalog-react/src/apis/StarredEntitiesApi/DefaultStarredEntitiesApi.ts
+2 -19
View File
@@ -50,27 +50,10 @@ export class DefaultStarredEntitiesApi implements StarredEntitiesApi {
const entityKey = buildEntityKey(entity);
if (this.starredEntities.has(entityKey)) {
await this.unstar(entity);
this.starredEntities.delete(entityKey);
} else {
await this.star(entity);
this.starredEntities.add(entityKey);
}
}
async star(entity: Entity): Promise<void> {
const entityKey = buildEntityKey(entity);
this.starredEntities.add(entityKey);
await this.settingsStore.set(
'starredEntities',
Array.from(this.starredEntities),
);
}
async unstar(entity: Entity): Promise<void> {
const entityKey = buildEntityKey(entity);
this.starredEntities.delete(entityKey);
await this.settingsStore.set(
'starredEntities',