From 56f0ef983e6bcaa1221beaa9cdfd1a94d51db1ee Mon Sep 17 00:00:00 2001
From: Dominik Henneke <dominik.henneke@sda-se.com>
Date: Tue, 12 Oct 2021 10:16:30 +0200
Subject: [PATCH] Remove the star and unstar method from
 DefaultStarredEntitiesApi

Signed-off-by: Dominik Henneke <dominik.henneke@sda-se.com>
---
 plugins/catalog-react/api-report.md           |  4 --
 .../DefaultStarredEntitiesApi.test.ts         | 42 -------------------
 .../DefaultStarredEntitiesApi.ts              | 21 +---------
 3 files changed, 2 insertions(+), 65 deletions(-)

diff --git a/plugins/catalog-react/api-report.md b/plugins/catalog-react/api-report.md
index 0accacce3e..12ae143d8a 100644
--- a/plugins/catalog-react/api-report.md
+++ b/plugins/catalog-react/api-report.md
@@ -141,13 +141,9 @@ export class DefaultStarredEntitiesApi implements StarredEntitiesApi {
   // (undocumented)
   isStarred(entity: Entity): boolean;
   // (undocumented)
-  star(entity: Entity): Promise<void>;
-  // (undocumented)
   starredEntitie$(): Observable<StarredEntitiesApiObservable>;
   // (undocumented)
   toggleStarred(entity: Entity): Promise<void>;
-  // (undocumented)
-  unstar(entity: Entity): Promise<void>;
 }
 
 // Warning: (ae-forgotten-export) The symbol "EntityLoadingStatus" needs to be exported by the entry point index.d.ts
diff --git a/plugins/catalog-react/src/apis/StarredEntitiesApi/DefaultStarredEntitiesApi.test.ts b/plugins/catalog-react/src/apis/StarredEntitiesApi/DefaultStarredEntitiesApi.test.ts
index c182bdad39..1edcdf706b 100644
--- a/plugins/catalog-react/src/apis/StarredEntitiesApi/DefaultStarredEntitiesApi.test.ts
+++ b/plugins/catalog-react/src/apis/StarredEntitiesApi/DefaultStarredEntitiesApi.test.ts
@@ -63,48 +63,6 @@ describe('DefaultStarredEntitiesApi', () => {
     });
   });
 
-  describe('star', () => {
-    it('should star unstarred entity', async () => {
-      expect(starredEntitiesApi.isStarred(mockEntity)).toBe(false);
-
-      await starredEntitiesApi.star(mockEntity);
-
-      expect(starredEntitiesApi.isStarred(mockEntity)).toBe(true);
-    });
-
-    it('should keep starred entity', async () => {
-      const bucket = mockStorage.forBucket('settings');
-      await bucket.set('starredEntities', ['entity:Component:default:mock']);
-
-      expect(starredEntitiesApi.isStarred(mockEntity)).toBe(true);
-
-      await starredEntitiesApi.star(mockEntity);
-
-      expect(starredEntitiesApi.isStarred(mockEntity)).toBe(true);
-    });
-  });
-
-  describe('unstar', () => {
-    it('should unstar starred entity', async () => {
-      const bucket = mockStorage.forBucket('settings');
-      await bucket.set('starredEntities', ['entity:Component:default:mock']);
-
-      expect(starredEntitiesApi.isStarred(mockEntity)).toBe(true);
-
-      await starredEntitiesApi.unstar(mockEntity);
-
-      expect(starredEntitiesApi.isStarred(mockEntity)).toBe(false);
-    });
-
-    it('should keep unstarred entity', async () => {
-      expect(starredEntitiesApi.isStarred(mockEntity)).toBe(false);
-
-      await starredEntitiesApi.unstar(mockEntity);
-
-      expect(starredEntitiesApi.isStarred(mockEntity)).toBe(false);
-    });
-  });
-
   describe('starredEntities$', () => {
     const handler = jest.fn();
 
diff --git a/plugins/catalog-react/src/apis/StarredEntitiesApi/DefaultStarredEntitiesApi.ts b/plugins/catalog-react/src/apis/StarredEntitiesApi/DefaultStarredEntitiesApi.ts
index 6080cc4e39..4c5ea63cf9 100644
--- a/plugins/catalog-react/src/apis/StarredEntitiesApi/DefaultStarredEntitiesApi.ts
+++ b/plugins/catalog-react/src/apis/StarredEntitiesApi/DefaultStarredEntitiesApi.ts
@@ -50,27 +50,10 @@ export class DefaultStarredEntitiesApi implements StarredEntitiesApi {
     const entityKey = buildEntityKey(entity);
 
     if (this.starredEntities.has(entityKey)) {
-      await this.unstar(entity);
+      this.starredEntities.delete(entityKey);
     } else {
-      await this.star(entity);
+      this.starredEntities.add(entityKey);
     }
-  }
-
-  async star(entity: Entity): Promise<void> {
-    const entityKey = buildEntityKey(entity);
-
-    this.starredEntities.add(entityKey);
-
-    await this.settingsStore.set(
-      'starredEntities',
-      Array.from(this.starredEntities),
-    );
-  }
-
-  async unstar(entity: Entity): Promise<void> {
-    const entityKey = buildEntityKey(entity);
-
-    this.starredEntities.delete(entityKey);
 
     await this.settingsStore.set(
       'starredEntities',