Apply suggestions from code review
Co-authored-by: Himanshu Mishra <himanshu@orkohunter.net> Signed-off-by: Jonah Back <jonah@jonahback.com>
This commit is contained in:
@@ -2,4 +2,4 @@
|
||||
'@backstage/plugin-kubernetes-backend': patch
|
||||
---
|
||||
|
||||
Use AWS SDK V2 for Kubernetes authentication
|
||||
Use AWS SDK V2 instead of V3 for Kubernetes authentication
|
||||
|
||||
+1
-1
@@ -46,6 +46,6 @@ describe('AwsIamKubernetesAuthTranslator tests', () => {
|
||||
url: '',
|
||||
authProvider: 'aws',
|
||||
});
|
||||
await expect(promise).rejects.toThrow('no credentials found');
|
||||
await expect(promise).rejects.toThrow('no AWS credentials found.');
|
||||
});
|
||||
});
|
||||
|
||||
+1
-1
@@ -34,7 +34,7 @@ export class AwsIamKubernetesAuthTranslator
|
||||
async getBearerToken(clusterName: string): Promise<string> {
|
||||
const credentials = AWS.config.credentials;
|
||||
if (!(credentials instanceof Credentials)) {
|
||||
throw new Error('no credentials found');
|
||||
throw new Error('no AWS credentials found.');
|
||||
}
|
||||
await credentials.getPromise();
|
||||
const request = {
|
||||
|
||||
Reference in New Issue
Block a user