From 401698abc12956a0560afd1891254b631aeeb9bf Mon Sep 17 00:00:00 2001 From: Jonah Back Date: Thu, 4 Mar 2021 15:19:24 -0800 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Himanshu Mishra Signed-off-by: Jonah Back --- .changeset/big-pumpkins-rush.md | 2 +- .../AwsIamKubernetesAuthTranslator.test.ts | 2 +- .../AwsIamKubernetesAuthTranslator.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.changeset/big-pumpkins-rush.md b/.changeset/big-pumpkins-rush.md index 6d74a0fb66..3a105f0e79 100644 --- a/.changeset/big-pumpkins-rush.md +++ b/.changeset/big-pumpkins-rush.md @@ -2,4 +2,4 @@ '@backstage/plugin-kubernetes-backend': patch --- -Use AWS SDK V2 for Kubernetes authentication +Use AWS SDK V2 instead of V3 for Kubernetes authentication diff --git a/plugins/kubernetes-backend/src/kubernetes-auth-translator/AwsIamKubernetesAuthTranslator.test.ts b/plugins/kubernetes-backend/src/kubernetes-auth-translator/AwsIamKubernetesAuthTranslator.test.ts index 84de03997e..08752f6ba1 100644 --- a/plugins/kubernetes-backend/src/kubernetes-auth-translator/AwsIamKubernetesAuthTranslator.test.ts +++ b/plugins/kubernetes-backend/src/kubernetes-auth-translator/AwsIamKubernetesAuthTranslator.test.ts @@ -46,6 +46,6 @@ describe('AwsIamKubernetesAuthTranslator tests', () => { url: '', authProvider: 'aws', }); - await expect(promise).rejects.toThrow('no credentials found'); + await expect(promise).rejects.toThrow('no AWS credentials found.'); }); }); diff --git a/plugins/kubernetes-backend/src/kubernetes-auth-translator/AwsIamKubernetesAuthTranslator.ts b/plugins/kubernetes-backend/src/kubernetes-auth-translator/AwsIamKubernetesAuthTranslator.ts index e5b6fb61d4..6d1dc774b9 100644 --- a/plugins/kubernetes-backend/src/kubernetes-auth-translator/AwsIamKubernetesAuthTranslator.ts +++ b/plugins/kubernetes-backend/src/kubernetes-auth-translator/AwsIamKubernetesAuthTranslator.ts @@ -34,7 +34,7 @@ export class AwsIamKubernetesAuthTranslator async getBearerToken(clusterName: string): Promise { const credentials = AWS.config.credentials; if (!(credentials instanceof Credentials)) { - throw new Error('no credentials found'); + throw new Error('no AWS credentials found.'); } await credentials.getPromise(); const request = {