Remove children from Skeleton and Avatar propDefs
Children was incorrectly added to OwnProps/propDefs during migration, causing useDefinition to extract it from restProps. Since neither component consumes children directly, children should flow through restProps to the underlying div element. Signed-off-by: Johan Persson <johanopersson@gmail.com>
This commit is contained in:
@@ -273,7 +273,6 @@ export const AvatarDefinition: {
|
||||
};
|
||||
readonly src: {};
|
||||
readonly name: {};
|
||||
readonly children: {};
|
||||
readonly className: {};
|
||||
};
|
||||
};
|
||||
@@ -284,7 +283,6 @@ export type AvatarOwnProps = {
|
||||
name: string;
|
||||
size?: 'x-small' | 'small' | 'medium' | 'large' | 'x-large';
|
||||
purpose?: 'decoration' | 'informative';
|
||||
children?: React.ReactNode;
|
||||
className?: string;
|
||||
};
|
||||
|
||||
@@ -2096,7 +2094,6 @@ export const SkeletonDefinition: {
|
||||
readonly dataAttribute: true;
|
||||
readonly default: false;
|
||||
};
|
||||
readonly children: {};
|
||||
readonly className: {};
|
||||
readonly style: {};
|
||||
};
|
||||
@@ -2107,7 +2104,6 @@ export type SkeletonOwnProps = {
|
||||
width?: number | string;
|
||||
height?: number | string;
|
||||
rounded?: boolean;
|
||||
children?: React.ReactNode;
|
||||
className?: string;
|
||||
style?: React.CSSProperties;
|
||||
};
|
||||
|
||||
@@ -34,7 +34,6 @@ export const AvatarDefinition = defineComponent<AvatarOwnProps>()({
|
||||
purpose: { default: 'informative' },
|
||||
src: {},
|
||||
name: {},
|
||||
children: {},
|
||||
className: {},
|
||||
},
|
||||
});
|
||||
|
||||
@@ -40,7 +40,6 @@ export type AvatarOwnProps = {
|
||||
*/
|
||||
purpose?: 'decoration' | 'informative';
|
||||
|
||||
children?: React.ReactNode;
|
||||
className?: string;
|
||||
};
|
||||
|
||||
|
||||
@@ -31,7 +31,6 @@ export const SkeletonDefinition = defineComponent<SkeletonOwnProps>()({
|
||||
width: { default: 80 },
|
||||
height: { default: 24 },
|
||||
rounded: { dataAttribute: true, default: false },
|
||||
children: {},
|
||||
className: {},
|
||||
style: {},
|
||||
},
|
||||
|
||||
@@ -21,7 +21,6 @@ export type SkeletonOwnProps = {
|
||||
width?: number | string;
|
||||
height?: number | string;
|
||||
rounded?: boolean;
|
||||
children?: React.ReactNode;
|
||||
className?: string;
|
||||
style?: React.CSSProperties;
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user