From 3f2c27a1e42e0b26cd71e2ca2a2c1a9992e34225 Mon Sep 17 00:00:00 2001
From: Johan Persson <johanopersson@gmail.com>
Date: Fri, 27 Feb 2026 12:34:28 +0100
Subject: [PATCH] Remove children from Skeleton and Avatar propDefs

Children was incorrectly added to OwnProps/propDefs during migration,
causing useDefinition to extract it from restProps. Since neither
component consumes children directly, children should flow through
restProps to the underlying div element.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
---
 packages/ui/report.api.md                         | 4 ----
 packages/ui/src/components/Avatar/definition.ts   | 1 -
 packages/ui/src/components/Avatar/types.ts        | 1 -
 packages/ui/src/components/Skeleton/definition.ts | 1 -
 packages/ui/src/components/Skeleton/types.ts      | 1 -
 5 files changed, 8 deletions(-)

diff --git a/packages/ui/report.api.md b/packages/ui/report.api.md
index bcb4466307..237fd655cd 100644
--- a/packages/ui/report.api.md
+++ b/packages/ui/report.api.md
@@ -273,7 +273,6 @@ export const AvatarDefinition: {
     };
     readonly src: {};
     readonly name: {};
-    readonly children: {};
     readonly className: {};
   };
 };
@@ -284,7 +283,6 @@ export type AvatarOwnProps = {
   name: string;
   size?: 'x-small' | 'small' | 'medium' | 'large' | 'x-large';
   purpose?: 'decoration' | 'informative';
-  children?: React.ReactNode;
   className?: string;
 };
 
@@ -2096,7 +2094,6 @@ export const SkeletonDefinition: {
       readonly dataAttribute: true;
       readonly default: false;
     };
-    readonly children: {};
     readonly className: {};
     readonly style: {};
   };
@@ -2107,7 +2104,6 @@ export type SkeletonOwnProps = {
   width?: number | string;
   height?: number | string;
   rounded?: boolean;
-  children?: React.ReactNode;
   className?: string;
   style?: React.CSSProperties;
 };
diff --git a/packages/ui/src/components/Avatar/definition.ts b/packages/ui/src/components/Avatar/definition.ts
index 480dee7066..8af18659d0 100644
--- a/packages/ui/src/components/Avatar/definition.ts
+++ b/packages/ui/src/components/Avatar/definition.ts
@@ -34,7 +34,6 @@ export const AvatarDefinition = defineComponent<AvatarOwnProps>()({
     purpose: { default: 'informative' },
     src: {},
     name: {},
-    children: {},
     className: {},
   },
 });
diff --git a/packages/ui/src/components/Avatar/types.ts b/packages/ui/src/components/Avatar/types.ts
index 875c753214..257a268f5e 100644
--- a/packages/ui/src/components/Avatar/types.ts
+++ b/packages/ui/src/components/Avatar/types.ts
@@ -40,7 +40,6 @@ export type AvatarOwnProps = {
    */
   purpose?: 'decoration' | 'informative';
 
-  children?: React.ReactNode;
   className?: string;
 };
 
diff --git a/packages/ui/src/components/Skeleton/definition.ts b/packages/ui/src/components/Skeleton/definition.ts
index 518cecfcb7..ec2950de8a 100644
--- a/packages/ui/src/components/Skeleton/definition.ts
+++ b/packages/ui/src/components/Skeleton/definition.ts
@@ -31,7 +31,6 @@ export const SkeletonDefinition = defineComponent<SkeletonOwnProps>()({
     width: { default: 80 },
     height: { default: 24 },
     rounded: { dataAttribute: true, default: false },
-    children: {},
     className: {},
     style: {},
   },
diff --git a/packages/ui/src/components/Skeleton/types.ts b/packages/ui/src/components/Skeleton/types.ts
index 24ba396c5c..5d9f644677 100644
--- a/packages/ui/src/components/Skeleton/types.ts
+++ b/packages/ui/src/components/Skeleton/types.ts
@@ -21,7 +21,6 @@ export type SkeletonOwnProps = {
   width?: number | string;
   height?: number | string;
   rounded?: boolean;
-  children?: React.ReactNode;
   className?: string;
   style?: React.CSSProperties;
 };