backend-app-api: fix cookie delete response

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>

packages/backend-app-api/src/services/implementations/httpRouter/createCookieAuthRefreshMiddleware.test.ts

@@ -43,7 +43,7 @@ describe('createCookieAuthRefreshMiddleware', () => {
 
   it('should remove the user cookie', async () => {
     const response = await request(app).delete('/.backstage/auth/v1/cookie');
-    expect(response.status).toBe(200);
+    expect(response.status).toBe(204);
     expect(response.header['set-cookie'][0]).toMatch('backstage-auth=');
   });
 });

packages/backend-app-api/src/services/implementations/httpRouter/createCookieAuthRefreshMiddleware.ts

@@ -40,7 +40,7 @@ export function createCookieAuthRefreshMiddleware(options: {
   router.delete(WELL_KNOWN_COOKIE_PATH_V1, async (_, res) => {
     const credentials = await auth.getNoneCredentials();
     await httpAuth.issueUserCookie(res, { credentials });
-    res.send(200);
+    res.status(204).end();
   });
 
   return router;