From 30c7ed4badb4d2c4d285ece1bf650c8bc536a57e Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Tue, 9 Apr 2024 15:17:33 +0200 Subject: [PATCH] backend-app-api: fix cookie delete response Signed-off-by: Patrik Oldsberg --- .../httpRouter/createCookieAuthRefreshMiddleware.test.ts | 2 +- .../httpRouter/createCookieAuthRefreshMiddleware.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/backend-app-api/src/services/implementations/httpRouter/createCookieAuthRefreshMiddleware.test.ts b/packages/backend-app-api/src/services/implementations/httpRouter/createCookieAuthRefreshMiddleware.test.ts index aa5f1a995a..6ecd52bbbf 100644 --- a/packages/backend-app-api/src/services/implementations/httpRouter/createCookieAuthRefreshMiddleware.test.ts +++ b/packages/backend-app-api/src/services/implementations/httpRouter/createCookieAuthRefreshMiddleware.test.ts @@ -43,7 +43,7 @@ describe('createCookieAuthRefreshMiddleware', () => { it('should remove the user cookie', async () => { const response = await request(app).delete('/.backstage/auth/v1/cookie'); - expect(response.status).toBe(200); + expect(response.status).toBe(204); expect(response.header['set-cookie'][0]).toMatch('backstage-auth='); }); }); diff --git a/packages/backend-app-api/src/services/implementations/httpRouter/createCookieAuthRefreshMiddleware.ts b/packages/backend-app-api/src/services/implementations/httpRouter/createCookieAuthRefreshMiddleware.ts index 1f3d497ce9..c33af7df4f 100644 --- a/packages/backend-app-api/src/services/implementations/httpRouter/createCookieAuthRefreshMiddleware.ts +++ b/packages/backend-app-api/src/services/implementations/httpRouter/createCookieAuthRefreshMiddleware.ts @@ -40,7 +40,7 @@ export function createCookieAuthRefreshMiddleware(options: { router.delete(WELL_KNOWN_COOKIE_PATH_V1, async (_, res) => { const credentials = await auth.getNoneCredentials(); await httpAuth.issueUserCookie(res, { credentials }); - res.send(200); + res.status(204).end(); }); return router;