Merge pull request #17707 from luchillo17/fix/BCKSTG-154-keyboard-navigation---compone

fix(core-components): Fix accessibility issue with Table headers
This commit is contained in:
Johan Haals
2023-05-09 10:29:20 +02:00
committed by GitHub
3 changed files with 6 additions and 6 deletions
+6
View File
@@ -0,0 +1,6 @@
---
'@backstage/core-components': patch
'@backstage/theme': patch
---
Fix accessibility issue with Backstage Table's header style
@@ -105,7 +105,6 @@ const StyledMTableHeader = withStyles(
borderTop: `1px solid ${theme.palette.grey.A100}`,
borderBottom: `1px solid ${theme.palette.grey.A100}`,
// withStyles hasn't a generic overload for theme
color: (theme as BackstageTheme).palette.textSubtle,
fontWeight: theme.typography.fontWeightBold,
position: 'static',
wordBreak: 'normal',
-5
View File
@@ -159,7 +159,6 @@ export function createThemeOverrides(theme: BackstageTheme): Overrides {
head: {
wordBreak: 'break-word',
overflow: 'hidden',
color: theme.palette.textSubtle,
fontWeight: 'normal',
lineHeight: '1',
},
@@ -198,14 +197,10 @@ export function createThemeOverrides(theme: BackstageTheme): Overrides {
'&:hover': {
color: 'inherit',
},
'&:focus': {
color: 'inherit',
},
},
// Bold font for highlighting selected column
active: {
fontWeight: 'bold',
color: 'inherit',
},
},
MuiListItemText: {