From eb1fcf5df023247f20fab5df51c0e641887cf456 Mon Sep 17 00:00:00 2001 From: Carlos Esteban Lopez Date: Mon, 8 May 2023 16:26:51 -0500 Subject: [PATCH 1/2] fix(core-components): Fix accessibility issue with Table headers Signed-off-by: Carlos Esteban Lopez --- packages/core-components/src/components/Table/Table.tsx | 1 - packages/theme/src/baseTheme.ts | 5 ----- 2 files changed, 6 deletions(-) diff --git a/packages/core-components/src/components/Table/Table.tsx b/packages/core-components/src/components/Table/Table.tsx index 848c85eb60..5cea3dd6b6 100644 --- a/packages/core-components/src/components/Table/Table.tsx +++ b/packages/core-components/src/components/Table/Table.tsx @@ -105,7 +105,6 @@ const StyledMTableHeader = withStyles( borderTop: `1px solid ${theme.palette.grey.A100}`, borderBottom: `1px solid ${theme.palette.grey.A100}`, // withStyles hasn't a generic overload for theme - color: (theme as BackstageTheme).palette.textSubtle, fontWeight: theme.typography.fontWeightBold, position: 'static', wordBreak: 'normal', diff --git a/packages/theme/src/baseTheme.ts b/packages/theme/src/baseTheme.ts index 53f3a3ef2b..c0a9022bd0 100644 --- a/packages/theme/src/baseTheme.ts +++ b/packages/theme/src/baseTheme.ts @@ -159,7 +159,6 @@ export function createThemeOverrides(theme: BackstageTheme): Overrides { head: { wordBreak: 'break-word', overflow: 'hidden', - color: theme.palette.textSubtle, fontWeight: 'normal', lineHeight: '1', }, @@ -198,14 +197,10 @@ export function createThemeOverrides(theme: BackstageTheme): Overrides { '&:hover': { color: 'inherit', }, - '&:focus': { - color: 'inherit', - }, }, // Bold font for highlighting selected column active: { fontWeight: 'bold', - color: 'inherit', }, }, MuiListItemText: { From 83b45f9df50de34e707e489dc52dd18c934f9a3a Mon Sep 17 00:00:00 2001 From: Carlos Esteban Lopez Date: Mon, 8 May 2023 16:38:22 -0500 Subject: [PATCH 2/2] fix(core-components): Add changeset Signed-off-by: Carlos Esteban Lopez --- .changeset/ninety-eggs-lie.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/ninety-eggs-lie.md diff --git a/.changeset/ninety-eggs-lie.md b/.changeset/ninety-eggs-lie.md new file mode 100644 index 0000000000..83b04b82af --- /dev/null +++ b/.changeset/ninety-eggs-lie.md @@ -0,0 +1,6 @@ +--- +'@backstage/core-components': patch +'@backstage/theme': patch +--- + +Fix accessibility issue with Backstage Table's header style