Rename based on feedback
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
This commit is contained in:
@@ -108,7 +108,7 @@ export function createGithubIssuesLabelAction(options: {
|
||||
>;
|
||||
|
||||
// @public
|
||||
export function createGithubPagesAction(options: {
|
||||
export function createGithubPagesEnableAction(options: {
|
||||
integrations: ScmIntegrationRegistry;
|
||||
githubCredentialsProvider?: GithubCredentialsProvider;
|
||||
}): TemplateAction<
|
||||
|
||||
+3
-3
@@ -22,8 +22,8 @@ import {
|
||||
GithubCredentialsProvider,
|
||||
ScmIntegrations,
|
||||
} from '@backstage/integration';
|
||||
import { createGithubPagesAction } from './githubPages';
|
||||
import { examples } from './githubPages.examples';
|
||||
import { createGithubPagesEnableAction } from './githubPagesEnable';
|
||||
import { examples } from './githubPagesEnable.examples';
|
||||
import yaml from 'yaml';
|
||||
|
||||
const mockOctokit = {
|
||||
@@ -60,7 +60,7 @@ describe('github:pages', () => {
|
||||
beforeEach(() => {
|
||||
githubCredentialsProvider =
|
||||
DefaultGithubCredentialsProvider.fromIntegrations(integrations);
|
||||
action = createGithubPagesAction({
|
||||
action = createGithubPagesEnableAction({
|
||||
integrations,
|
||||
githubCredentialsProvider,
|
||||
});
|
||||
+2
-2
@@ -22,7 +22,7 @@ import {
|
||||
GithubCredentialsProvider,
|
||||
ScmIntegrations,
|
||||
} from '@backstage/integration';
|
||||
import { createGithubPagesAction } from './githubPages';
|
||||
import { createGithubPagesEnableAction } from './githubPagesEnable';
|
||||
|
||||
const mockOctokit = {
|
||||
request: jest.fn(),
|
||||
@@ -63,7 +63,7 @@ describe('github:pages', () => {
|
||||
beforeEach(() => {
|
||||
githubCredentialsProvider =
|
||||
DefaultGithubCredentialsProvider.fromIntegrations(integrations);
|
||||
action = createGithubPagesAction({
|
||||
action = createGithubPagesEnableAction({
|
||||
integrations,
|
||||
githubCredentialsProvider,
|
||||
});
|
||||
+3
-3
@@ -24,7 +24,7 @@ import {
|
||||
createTemplateAction,
|
||||
parseRepoUrl,
|
||||
} from '@backstage/plugin-scaffolder-node';
|
||||
import { examples } from './githubPages.examples';
|
||||
import { examples } from './githubPagesEnable.examples';
|
||||
import { getOctokitOptions } from '@backstage/plugin-scaffolder-backend-module-github';
|
||||
|
||||
/**
|
||||
@@ -32,7 +32,7 @@ import { getOctokitOptions } from '@backstage/plugin-scaffolder-backend-module-g
|
||||
*
|
||||
* @public
|
||||
*/
|
||||
export function createGithubPagesAction(options: {
|
||||
export function createGithubPagesEnableAction(options: {
|
||||
integrations: ScmIntegrationRegistry;
|
||||
githubCredentialsProvider?: GithubCredentialsProvider;
|
||||
}) {
|
||||
@@ -45,7 +45,7 @@ export function createGithubPagesAction(options: {
|
||||
sourcePath?: '/' | '/docs';
|
||||
token?: string;
|
||||
}>({
|
||||
id: 'github:pages',
|
||||
id: 'github:pages:enable',
|
||||
examples,
|
||||
description: 'Enables GitHub Pages for a repository.',
|
||||
schema: {
|
||||
@@ -27,6 +27,6 @@ export {
|
||||
} from './githubPullRequest';
|
||||
export { createPublishGithubAction } from './github';
|
||||
export { createGithubAutolinksAction } from './githubAutolinks';
|
||||
export { createGithubPagesAction } from './githubPages';
|
||||
export { createGithubPagesEnableAction } from './githubPagesEnable';
|
||||
|
||||
export { getOctokitOptions } from './helpers';
|
||||
|
||||
@@ -29,7 +29,7 @@ import {
|
||||
createGithubWebhookAction,
|
||||
createPublishGithubAction,
|
||||
createPublishGithubPullRequestAction,
|
||||
createGithubPagesAction,
|
||||
createGithubPagesEnableAction,
|
||||
} from './actions';
|
||||
import {
|
||||
DefaultGithubCredentialsProvider,
|
||||
@@ -92,7 +92,7 @@ export const githubModule = createBackendModule({
|
||||
githubCredentialsProvider,
|
||||
config,
|
||||
}),
|
||||
createGithubPagesAction({
|
||||
createGithubPagesEnableAction({
|
||||
integrations,
|
||||
githubCredentialsProvider,
|
||||
}),
|
||||
|
||||
Reference in New Issue
Block a user