From 1469ddade4ee796fac4ebee923433594f3c1e72e Mon Sep 17 00:00:00 2001
From: Andre Wanlin <awanlin@spotify.com>
Date: Fri, 28 Jun 2024 15:43:55 -0500
Subject: [PATCH] Rename based on feedback

Signed-off-by: Andre Wanlin <awanlin@spotify.com>
---
 plugins/scaffolder-backend-module-github/api-report.md      | 2 +-
 ....examples.test.ts => githubPagesEnable.examples.test.ts} | 6 +++---
 ...ithubPages.examples.ts => githubPagesEnable.examples.ts} | 0
 .../{githubPages.test.ts => githubPagesEnable.test.ts}      | 4 ++--
 .../src/actions/{githubPages.ts => githubPagesEnable.ts}    | 6 +++---
 .../scaffolder-backend-module-github/src/actions/index.ts   | 2 +-
 plugins/scaffolder-backend-module-github/src/module.ts      | 4 ++--
 7 files changed, 12 insertions(+), 12 deletions(-)
 rename plugins/scaffolder-backend-module-github/src/actions/{githubPages.examples.test.ts => githubPagesEnable.examples.test.ts} (93%)
 rename plugins/scaffolder-backend-module-github/src/actions/{githubPages.examples.ts => githubPagesEnable.examples.ts} (100%)
 rename plugins/scaffolder-backend-module-github/src/actions/{githubPages.test.ts => githubPagesEnable.test.ts} (95%)
 rename plugins/scaffolder-backend-module-github/src/actions/{githubPages.ts => githubPagesEnable.ts} (96%)

diff --git a/plugins/scaffolder-backend-module-github/api-report.md b/plugins/scaffolder-backend-module-github/api-report.md
index aa4d94dcd6..0572052fd4 100644
--- a/plugins/scaffolder-backend-module-github/api-report.md
+++ b/plugins/scaffolder-backend-module-github/api-report.md
@@ -108,7 +108,7 @@ export function createGithubIssuesLabelAction(options: {
 >;
 
 // @public
-export function createGithubPagesAction(options: {
+export function createGithubPagesEnableAction(options: {
   integrations: ScmIntegrationRegistry;
   githubCredentialsProvider?: GithubCredentialsProvider;
 }): TemplateAction<
diff --git a/plugins/scaffolder-backend-module-github/src/actions/githubPages.examples.test.ts b/plugins/scaffolder-backend-module-github/src/actions/githubPagesEnable.examples.test.ts
similarity index 93%
rename from plugins/scaffolder-backend-module-github/src/actions/githubPages.examples.test.ts
rename to plugins/scaffolder-backend-module-github/src/actions/githubPagesEnable.examples.test.ts
index 7480d8d478..ee7b5caa65 100644
--- a/plugins/scaffolder-backend-module-github/src/actions/githubPages.examples.test.ts
+++ b/plugins/scaffolder-backend-module-github/src/actions/githubPagesEnable.examples.test.ts
@@ -22,8 +22,8 @@ import {
   GithubCredentialsProvider,
   ScmIntegrations,
 } from '@backstage/integration';
-import { createGithubPagesAction } from './githubPages';
-import { examples } from './githubPages.examples';
+import { createGithubPagesEnableAction } from './githubPagesEnable';
+import { examples } from './githubPagesEnable.examples';
 import yaml from 'yaml';
 
 const mockOctokit = {
@@ -60,7 +60,7 @@ describe('github:pages', () => {
   beforeEach(() => {
     githubCredentialsProvider =
       DefaultGithubCredentialsProvider.fromIntegrations(integrations);
-    action = createGithubPagesAction({
+    action = createGithubPagesEnableAction({
       integrations,
       githubCredentialsProvider,
     });
diff --git a/plugins/scaffolder-backend-module-github/src/actions/githubPages.examples.ts b/plugins/scaffolder-backend-module-github/src/actions/githubPagesEnable.examples.ts
similarity index 100%
rename from plugins/scaffolder-backend-module-github/src/actions/githubPages.examples.ts
rename to plugins/scaffolder-backend-module-github/src/actions/githubPagesEnable.examples.ts
diff --git a/plugins/scaffolder-backend-module-github/src/actions/githubPages.test.ts b/plugins/scaffolder-backend-module-github/src/actions/githubPagesEnable.test.ts
similarity index 95%
rename from plugins/scaffolder-backend-module-github/src/actions/githubPages.test.ts
rename to plugins/scaffolder-backend-module-github/src/actions/githubPagesEnable.test.ts
index 266f4c5a53..203014b67b 100644
--- a/plugins/scaffolder-backend-module-github/src/actions/githubPages.test.ts
+++ b/plugins/scaffolder-backend-module-github/src/actions/githubPagesEnable.test.ts
@@ -22,7 +22,7 @@ import {
   GithubCredentialsProvider,
   ScmIntegrations,
 } from '@backstage/integration';
-import { createGithubPagesAction } from './githubPages';
+import { createGithubPagesEnableAction } from './githubPagesEnable';
 
 const mockOctokit = {
   request: jest.fn(),
@@ -63,7 +63,7 @@ describe('github:pages', () => {
   beforeEach(() => {
     githubCredentialsProvider =
       DefaultGithubCredentialsProvider.fromIntegrations(integrations);
-    action = createGithubPagesAction({
+    action = createGithubPagesEnableAction({
       integrations,
       githubCredentialsProvider,
     });
diff --git a/plugins/scaffolder-backend-module-github/src/actions/githubPages.ts b/plugins/scaffolder-backend-module-github/src/actions/githubPagesEnable.ts
similarity index 96%
rename from plugins/scaffolder-backend-module-github/src/actions/githubPages.ts
rename to plugins/scaffolder-backend-module-github/src/actions/githubPagesEnable.ts
index 09910319fe..044005961e 100644
--- a/plugins/scaffolder-backend-module-github/src/actions/githubPages.ts
+++ b/plugins/scaffolder-backend-module-github/src/actions/githubPagesEnable.ts
@@ -24,7 +24,7 @@ import {
   createTemplateAction,
   parseRepoUrl,
 } from '@backstage/plugin-scaffolder-node';
-import { examples } from './githubPages.examples';
+import { examples } from './githubPagesEnable.examples';
 import { getOctokitOptions } from '@backstage/plugin-scaffolder-backend-module-github';
 
 /**
@@ -32,7 +32,7 @@ import { getOctokitOptions } from '@backstage/plugin-scaffolder-backend-module-g
  *
  * @public
  */
-export function createGithubPagesAction(options: {
+export function createGithubPagesEnableAction(options: {
   integrations: ScmIntegrationRegistry;
   githubCredentialsProvider?: GithubCredentialsProvider;
 }) {
@@ -45,7 +45,7 @@ export function createGithubPagesAction(options: {
     sourcePath?: '/' | '/docs';
     token?: string;
   }>({
-    id: 'github:pages',
+    id: 'github:pages:enable',
     examples,
     description: 'Enables GitHub Pages for a repository.',
     schema: {
diff --git a/plugins/scaffolder-backend-module-github/src/actions/index.ts b/plugins/scaffolder-backend-module-github/src/actions/index.ts
index e9a11e9377..6f37678099 100644
--- a/plugins/scaffolder-backend-module-github/src/actions/index.ts
+++ b/plugins/scaffolder-backend-module-github/src/actions/index.ts
@@ -27,6 +27,6 @@ export {
 } from './githubPullRequest';
 export { createPublishGithubAction } from './github';
 export { createGithubAutolinksAction } from './githubAutolinks';
-export { createGithubPagesAction } from './githubPages';
+export { createGithubPagesEnableAction } from './githubPagesEnable';
 
 export { getOctokitOptions } from './helpers';
diff --git a/plugins/scaffolder-backend-module-github/src/module.ts b/plugins/scaffolder-backend-module-github/src/module.ts
index a26fdd7d2d..a5676ab8c9 100644
--- a/plugins/scaffolder-backend-module-github/src/module.ts
+++ b/plugins/scaffolder-backend-module-github/src/module.ts
@@ -29,7 +29,7 @@ import {
   createGithubWebhookAction,
   createPublishGithubAction,
   createPublishGithubPullRequestAction,
-  createGithubPagesAction,
+  createGithubPagesEnableAction,
 } from './actions';
 import {
   DefaultGithubCredentialsProvider,
@@ -92,7 +92,7 @@ export const githubModule = createBackendModule({
             githubCredentialsProvider,
             config,
           }),
-          createGithubPagesAction({
+          createGithubPagesEnableAction({
             integrations,
             githubCredentialsProvider,
           }),