fix: code review

This commit is contained in:
Nikita Nek Dudnik
2020-07-16 11:11:19 +02:00
parent eda7f30da2
commit 0bfadd8676
2 changed files with 2 additions and 13 deletions
+2 -1
View File
@@ -84,8 +84,9 @@ export const apis = (config: ConfigApi) => {
new CircleCIApi(`${backendUrl}/proxy/circleci/api`),
);
const octokit = new Octokit();
const octokit = new Octokit({ auth: process.env.GITHUB_ACCESS_TOKEN });
builder.add(githubActionsApiRef, new GithubActionsClient({ api: octokit }));
builder.add(featureFlagsApiRef, new FeatureFlags());
builder.add(lighthouseApiRef, new LighthouseRestApi('http://localhost:3003'));
@@ -22,18 +22,6 @@ import {
ActionsGetWorkflowRunResponseData,
} from '@octokit/types';
// const statusToBuildStatus: { [status: string]: BuildStatus } = {
// success: BuildStatus.Success,
// failure: BuildStatus.Failure,
// pending: BuildStatus.Pending,
// running: BuildStatus.Running,
// in_progress: BuildStatus.Running,
// completed: BuildStatus.Success,
// };
// const conclusionToStatus = (conslusion: string): BuildStatus =>
// statusToBuildStatus[conslusion] ?? BuildStatus.Null;
export class GithubActionsClient implements GithubActionsApi {
private api: Octokit;
constructor({ api }: { api: Octokit }) {