From 0bfadd867693ebc9f21dd14f6695c44aa5640b03 Mon Sep 17 00:00:00 2001 From: Nikita Nek Dudnik Date: Thu, 16 Jul 2020 11:11:19 +0200 Subject: [PATCH] fix: code review --- packages/app/src/apis.ts | 3 ++- .../github-actions/src/api/GithubActionsClient.ts | 12 ------------ 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/packages/app/src/apis.ts b/packages/app/src/apis.ts index b72a5f1c6d..ca0e2298cf 100644 --- a/packages/app/src/apis.ts +++ b/packages/app/src/apis.ts @@ -84,8 +84,9 @@ export const apis = (config: ConfigApi) => { new CircleCIApi(`${backendUrl}/proxy/circleci/api`), ); - const octokit = new Octokit(); + const octokit = new Octokit({ auth: process.env.GITHUB_ACCESS_TOKEN }); builder.add(githubActionsApiRef, new GithubActionsClient({ api: octokit })); + builder.add(featureFlagsApiRef, new FeatureFlags()); builder.add(lighthouseApiRef, new LighthouseRestApi('http://localhost:3003')); diff --git a/plugins/github-actions/src/api/GithubActionsClient.ts b/plugins/github-actions/src/api/GithubActionsClient.ts index a22164e9c5..c2efa44539 100644 --- a/plugins/github-actions/src/api/GithubActionsClient.ts +++ b/plugins/github-actions/src/api/GithubActionsClient.ts @@ -22,18 +22,6 @@ import { ActionsGetWorkflowRunResponseData, } from '@octokit/types'; -// const statusToBuildStatus: { [status: string]: BuildStatus } = { -// success: BuildStatus.Success, -// failure: BuildStatus.Failure, -// pending: BuildStatus.Pending, -// running: BuildStatus.Running, -// in_progress: BuildStatus.Running, -// completed: BuildStatus.Success, -// }; - -// const conclusionToStatus = (conslusion: string): BuildStatus => -// statusToBuildStatus[conslusion] ?? BuildStatus.Null; - export class GithubActionsClient implements GithubActionsApi { private api: Octokit; constructor({ api }: { api: Octokit }) {