Commit Graph

658 Commits

Author SHA1 Message Date
Patrik Oldsberg cb24f975aa backend-common: added test to ensure malicious zip archives are handled
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-08-09 18:28:38 +02:00
Patrik Oldsberg 5e4dc173f7 backend-common: validate zip archive paths when unpacking into a dir
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-08-09 18:28:38 +02:00
Ben Lambert eacf97cc2b Merge pull request #12774 from jamieklassen/gitlab-unscoped
support unscoped routes in location targets on gitlab
2022-08-02 10:33:54 +02:00
Ben Lambert c7dd03bf96 Merge pull request #12718 from Charge71/master
feat(logging): export redactLogLine function
2022-07-28 14:01:25 +02:00
Diego Bardari ef4fd4abd1 feat(logging): renamed redactLogLine function to redactWinstonLogLine
Signed-off-by: Diego Bardari <diego.bardari@klarna.com>
2022-07-28 11:56:07 +02:00
Ben Lambert 8ecf0660a3 Merge pull request #12780 from andrewduckett/patch/plugin-division-mode
respect `ensureExists` when `pluginDivisionMode` is set to `schema`.
2022-07-25 22:07:05 +02:00
Ben Lambert 75bfc7317d Merge pull request #12711 from Bonial-International-GmbH/pjungermann/bitbucketServer/auth
feat: support Basic Auth and token-only at Git commands for Bitbucket Server
2022-07-25 17:06:08 +02:00
Patrick Jungermann 3b7930b3e5 feat: support Bearer auth header at git commands
Support Bearer-based Authorization header for auth
with token only (no username).

Signed-off-by: Patrick Jungermann <Patrick.Jungermann@gmail.com>
2022-07-25 15:53:30 +02:00
Ben Lambert f47d8aa55e Merge pull request #12090 from backstage/fix/broken-zip-files
Throw on corrupt ZIP files instead of hanging indefinitely
2022-07-25 15:31:33 +02:00
blam 764ba707a2 chore: refactor and comment
Signed-off-by: blam <ben@blam.sh>
2022-07-25 13:53:54 +02:00
Jamie Klassen 1e1e436e86 Look up project IDs for unscoped routes
Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2022-07-22 07:36:35 -04:00
Andrew Duckett 770d3f92c4 respect ensureExists when pluginDivisionMode is set to schema.
Signed-off-by: Andrew Duckett <andrew.duckett@gmail.com>
2022-07-21 22:21:53 -05:00
Ben Lambert 7495b78b7e Merge pull request #12748 from awanlin/bug/fix-bitbucket-server-getlastcommitshorthash
Added back support for when no branch is provided
2022-07-21 17:15:47 +02:00
blam 01d825ba28 chore: finish piping and stuff and making it lovely
Signed-off-by: blam <ben@blam.sh>
2022-07-21 16:31:02 +02:00
blam 22e9262868 chore: code-review comments
Signed-off-by: blam <ben@blam.sh>
2022-07-21 16:20:19 +02:00
Niya Ma 108f0de8df fix duplicate variable
Signed-off-by: Niya Ma <niyama12321@gmail.com>
2022-07-20 09:27:30 -07:00
Niya Ma 8e6a551507 Merge branch 'master' into add-git-force
Signed-off-by: Niya Ma <78030299+niya-ma-1@users.noreply.github.com>
2022-07-20 09:18:07 -07:00
Thomas Cardonne fc8a5f797b feat(scaffolder): add a publish:gerrit:review action
Signed-off-by: Thomas Cardonne <thomas.cardonne@adevinta.com>
2022-07-20 15:53:18 +02:00
Andre Wanlin 12e9b54f0e Added back support for when no branch is provided
Signed-off-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com>
2022-07-19 19:37:00 -05:00
Niya Ma 30012e7d8c Add force options to git wrapper
Signed-off-by: Niya Ma <niyama12321@gmail.com>
2022-07-19 15:32:06 -07:00
Diego Bardari 1732a18a7a feat(logging): export redactLogLine function
Signed-off-by: Diego Bardari <diego.bardari@klarna.com>
2022-07-19 11:40:47 +02:00
blam 14f6f11eec feat: added some more information to the error for the user
Signed-off-by: blam <ben@blam.sh>
2022-07-18 14:30:12 +02:00
ahmed 1379080c92 fix relative path edge case
Signed-off-by: ahmed <ahmed@planet.com>
2022-07-18 11:21:34 +02:00
blam e27ada575f chore: small re-factor, and update changeset
Signed-off-by: blam <ben@blam.sh>
2022-07-14 13:02:49 +02:00
blam 773fc2c4a5 chore: make better
Signed-off-by: blam <ben@blam.sh>
2022-07-14 12:05:56 +02:00
blam 0f473ecdc7 chore: remove the pauses
Signed-off-by: blam <ben@blam.sh>
2022-07-14 12:03:51 +02:00
blam 7642a14233 chore: looking so much better now
Signed-off-by: blam <ben@blam.sh>
2022-07-14 12:01:40 +02:00
blam e5a38fcead chore: refactoring some parts to make it actually run a little better
Signed-off-by: blam <ben@blam.sh>
2022-07-14 11:53:31 +02:00
blam a69b0cfc98 chore: fixing things and making them green for now, still a lot to do. Things don't resolve at the right time
Signed-off-by: blam <ben@blam.sh>

Signed-off-by: blam <ben@blam.sh>
2022-07-14 11:51:18 +02:00
blam 2b59c8ed4d chore: made some progress moving over to a new library for this
Signed-off-by: blam <ben@blam.sh>
2022-07-14 11:51:16 +02:00
Otto Sichert 6cd6946674 Ensure test ZIP file can't be read by Node 14 either
Signed-off-by: Otto Sichert <git@ottosichert.de>
2022-07-14 11:50:19 +02:00
Otto Sichert c878f1c9f3 Fix linter errors
Signed-off-by: Otto Sichert <git@ottosichert.de>
2022-07-14 11:50:19 +02:00
Otto Sichert b19d82600d Add tests for corrupted ZIP files
Signed-off-by: Otto Sichert <git@ottosichert.de>
2022-07-14 11:50:19 +02:00
Otto Sichert 9344fdf1b6 Simplify guarding against corrupt ZIP files
Signed-off-by: Otto Sichert <git@ottosichert.de>
2022-07-14 11:50:19 +02:00
Otto Sichert 72e34fe980 Restore original behaviour in listing ZIP directories
Signed-off-by: Otto Sichert <git@ottosichert.de>
2022-07-14 11:50:19 +02:00
Otto Sichert a6a11e52ef Ensure all ZIP operations handle timeouts correctly
Signed-off-by: Otto Sichert <git@ottosichert.de>
2022-07-14 11:50:19 +02:00
Otto Sichert 67e2671e23 Move stream timeout promise to util
Signed-off-by: Otto Sichert <git@ottosichert.de>
2022-07-14 11:50:19 +02:00
Otto Sichert cd973a35d8 Implement manual catching of corrupted ZIP files
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com>
Co-authored-by: Raghunandan Balachandran <soapraj@users.noreply.github.com>
Signed-off-by: Otto Sichert <git@ottosichert.de>
2022-07-14 11:50:19 +02:00
Ben Lambert 95c4faa8aa Merge pull request #12403 from OpenSourceZombie/ahmed/fix-gitlab-subpath
Consider hosted gitlab with relative path
2022-07-13 10:25:35 +02:00
ahmed 6f9f3b6936 rename variable and add relativePath check
Signed-off-by: ahmed <ahmed@planet.com>
2022-07-08 17:46:15 +02:00
ahmed f0f2e4f6b0 move relative path to a function
Signed-off-by: ahmed <ahmed@planet.com>
2022-07-06 22:35:27 +02:00
ahmed 419559d0e7 consider hosted gitlab with relative path
Signed-off-by: ahmed <ahmed@planet.com>
2022-07-06 22:35:27 +02:00
Carlo Giuseppe Sergi 90c87f28e8 fix the getLastCommitShortHash and changed the endpoint
Signed-off-by: Carlo Giuseppe Sergi <carlo.sergi@klarna.com>
2022-07-06 17:14:13 +02:00
Ben Lambert d4bf53b434 Merge pull request #12188 from backstage/renovate/knex-2.x
fix(deps): update dependency knex to v2
2022-06-29 11:31:27 +02:00
blam 14d5eca8d3 chore: fixing typings
Signed-off-by: blam <ben@blam.sh>
2022-06-29 10:46:32 +02:00
Adam Harvey c5270e31a2 Improve plural handling in log output
Signed-off-by: Adam Harvey <adaharve@cisco.com>
2022-06-21 22:49:29 -04:00
Patrik Oldsberg 6532c8084a remove usage of @ts-ignore
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-06-17 18:03:58 +02:00
Patrick Jungermann b1edb5cfd9 fix: fix parsing of S3 URLs for the default region
Closes: #11913
Signed-off-by: Patrick Jungermann <Patrick.Jungermann@gmail.com>
2022-06-15 14:26:05 +02:00
Johan Haals c3cfc83af2 chore: Make docstrings MDX compatible
Signed-off-by: Johan Haals <johan.haals@gmail.com>
2022-06-14 16:29:17 +02:00
Patrik Oldsberg 55647ec7df backend-common: prevent expired backend tokens from being used
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-06-02 13:46:31 +02:00