Commit Graph

7482 Commits

Author SHA1 Message Date
Patrik Oldsberg ef3adaf8d6 catalog-import: switch tests back to sync to be sure it works
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-10-17 13:16:42 +02:00
Eric Peterson 99563aacb3 Merge pull request #7635 from SDA-SE/feat/fix-techdocs-flickering 2021-10-17 12:14:12 +02:00
Patrik Oldsberg c9858922d0 Merge pull request #7645 from backstage/rugvip/scaffoodlin
scaffolder-backend: use mock-fs in workflow runner tests
2021-10-16 17:38:23 +02:00
Patrik Oldsberg a45682be4e scaffolder-backend: use mock-fs in workflow runner tests
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-10-16 14:58:35 +02:00
Patrik Oldsberg 6968962c92 scaffolder-backend: release path traversal fix
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-10-16 14:00:24 +02:00
Patrik Oldsberg 5ea950075d scaffolder-backend: extra safety around resolving source paths
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-10-16 13:39:56 +02:00
Patrik Oldsberg 1bcd771342 Merge pull request #7588 from SDA-SE/feat/githubpraction
Make sure `sourcePath` of `publish:github:pull-request` can only be used to retrieve files from the workspace.
2021-10-16 13:16:12 +02:00
Dominik Henneke cdf8ca6111 Only replace the shadow dom if the content is changed to avoid a flickering UI
Signed-off-by: Dominik Henneke <dominik.henneke@sda-se.com>
2021-10-15 17:14:12 +02:00
Crevil de3e26aecc Fix refresh reuse bug in Github provider
Currently when the Github provider refreshes an access token it doesn't forward
the new refresh token to the caller. As Github only allows refresh tokens to be
used once, the next refresh call will fail.

This change fixes the bug by returning the new refresh token upon refresh.

This change is similar to 25a613bdd7 (#7110) for
the GitLab provider.

Signed-off-by: Crevil <bjoern.soerensen@gmail.com>
2021-10-14 21:26:43 +02:00
github-actions[bot] 4c840cebfa Version Packages 2021-10-14 12:45:08 +00:00
Patrik Oldsberg efdefe673f Merge pull request #7410 from SDA-SE/feat/starredentitiesapi
Introduce a new `StarredEntitiesApi` that is used in the `useStarredEntities` hook
2021-10-14 14:39:19 +02:00
Ben Lambert dc93d20204 Merge pull request #7355 from backstage/feat/blam/nunjucks-template
Add support for `scaffolder.backstage.io/v1beta3` Software Templates
2021-10-14 13:52:25 +02:00
Fredrik Adelöw 03d306945e Merge pull request #7584 from SDA-SE/feat/fetch-resolvesafe
Use `resolveSafeChildPath` in the `fetchContents` function
2021-10-14 12:18:34 +02:00
Dominik Henneke 5b57ba36f0 Provide a migration from the old storage location and format to the new one
Signed-off-by: Dominik Henneke <dominik.henneke@sda-se.com>
2021-10-14 12:08:46 +02:00
Dominik Henneke 4ec21812bb Fix import
Signed-off-by: Dominik Henneke <dominik.henneke@sda-se.com>
2021-10-14 12:08:46 +02:00
Dominik Henneke 0366c9b667 Introduce a useStarredEntity hook to check if a single entity is starred
Signed-off-by: Dominik Henneke <dominik.henneke@sda-se.com>
2021-10-14 12:08:45 +02:00
Dominik Henneke 1dbaaf7801 Simplify the StarredEntitiesApi interface
Signed-off-by: Dominik Henneke <dominik.henneke@sda-se.com>
2021-10-14 12:08:45 +02:00
Dominik Henneke bd924fece8 Add additional docs
Signed-off-by: Dominik Henneke <dominik.henneke@sda-se.com>
2021-10-14 12:08:45 +02:00
Dominik Henneke c1d50273de Use entity references in the StarredEntitiesApi
Signed-off-by: Dominik Henneke <dominik.henneke@sda-se.com>
2021-10-14 12:08:44 +02:00
Dominik Henneke 78fcb898c4 Rename the storage location of the starred entities from /settings/starredEntities to /starredEntitites/entitifyRefs
Signed-off-by: Dominik Henneke <dominik.henneke@sda-se.com>
2021-10-14 12:08:44 +02:00
Dominik Henneke 615f668d31 Use entity refs as a storage format instead of the custom one
Signed-off-by: Dominik Henneke <dominik.henneke@sda-se.com>
2021-10-14 12:08:44 +02:00
Dominik Henneke 56f0ef983e Remove the star and unstar method from DefaultStarredEntitiesApi
Signed-off-by: Dominik Henneke <dominik.henneke@sda-se.com>
2021-10-14 12:08:43 +02:00
Dominik Henneke 8f55fb815b Fix test
Signed-off-by: Dominik Henneke <dominik.henneke@sda-se.com>
2021-10-14 12:08:43 +02:00
Dominik Henneke 126daa5ec3 Resolve PR comments
* rename starredEntities$ to starredEntitie$
* delete star and unstar from the public interface

Signed-off-by: Dominik Henneke <dominik.henneke@sda-se.com>
2021-10-14 12:08:42 +02:00
Dominik Henneke 82fbda923e Introduce a new StarredEntitiesApi that is used in the useStarredEntities hook
Signed-off-by: Dominik Henneke <dominik.henneke@sda-se.com>
2021-10-14 12:08:42 +02:00
blam f71fda7600 chore: removing double log Lines
Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:20 +02:00
blam 7fe6c0bb70 chore: reworking the docs a little bit
Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:20 +02:00
blam 17d7f5bc57 feat: removing the older stuff and updating to work with the new common packages
Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:20 +02:00
blam b1d5d584e5 chore: updating the version string
Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:20 +02:00
blam 5118da771f chore: remove the changes for catalog-backend too
Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:20 +02:00
blam ca9c69f3a8 chore: fix code review comments
Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:20 +02:00
blam f39de106b5 chore: only dump when there's only one param ref
Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:20 +02:00
blam cbe2803100 chore: remove the hackery and wrap up the template stringify
Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:20 +02:00
blam f8355c99cb chore: remove all tracked temp directories and make sure to emit the processing and skipped events
Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:20 +02:00
blam 5bdbb6caec chore: fix up some types
Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:20 +02:00
blam 154b86e1da feat: think we're at feature parity
Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:19 +02:00
blam fe2324e630 chore: added validation for schemas for actions
Signed-off-by: blam <ben@blam.sh>

Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:19 +02:00
blam c7b089a5ae chore: adding the new if syntax and using the power of nunjucks
Signed-off-by: blam <ben@blam.sh
Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:19 +02:00
blam 1ec5ef3699 chore: acutally make the scaffolder backend run the v3 template
Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:19 +02:00
blam 34b1278929 chore: worked out a niceish way to template objects and stuff as first class citizens
Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:19 +02:00
blam 6ab1202fc8 feat: rework the TaskWorker to just be concerned with the task delegation
Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:19 +02:00
blam 4e005b13cf feat: moving all the legacy tests over to the new LegacyWorkflowRunner tests
Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:19 +02:00
blam edb04593ff feat(TaskWorker): move out the logic into the WorkflowRunner implementations
Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:19 +02:00
blam e3dbdf6679 feat(TaskWorker): split the parsing of the templates with the new syntax
Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:19 +02:00
blam ccea0b8271 feat(catalog-backend): add the new kind to the validation workflow
Signed-off-by: blam <ben@blam.sh>
2021-10-14 12:07:19 +02:00
blam 88faa29c76 chore: force swagger-client to 3.16.1 because of removal of dependency
Signed-off-by: blam <ben@blam.sh>
2021-10-14 11:44:19 +02:00
Fredrik Adelöw 87e6a88418 Merge pull request #7585 from backstage/freben/async-test
made more tests async
2021-10-13 16:48:36 +02:00
Oliver Sand 853bbfe302 Add tests for getRepoSourceDirectory
Signed-off-by: Oliver Sand <oliver.sand@sda-se.com>
2021-10-13 16:35:10 +02:00
Oliver Sand 0f99f1170e Make sure sourcePath of publish:github:pull-request can only be used to retrieve files from the workspace
Signed-off-by: Oliver Sand <oliver.sand@sda-se.com>
2021-10-13 16:35:10 +02:00
Fredrik Adelöw 9f6c4233ac made more tests async
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-10-13 16:18:59 +02:00