The empty state's description is already wrapped in a Typography component so the one in MissingImplementsApisEmptyState is redundant.
https://github.com/backstage/backstage/blob/bbaadb63f88d0f7d42acb9fa1b1644f85bf1043e/packages/core/src/components/EmptyState/EmptyState.tsx#L57
By wrapping the EmptyState's description in a Typography the following warning is output to the console
```
react-dom.development.js?1930:89 Warning: validateDOMNesting(...): <p> cannot appear as a descendant of <p>.
in p (created by ForwardRef(Typography))
in ForwardRef(Typography) (created by WithStyles(ForwardRef(Typography)))
in WithStyles(ForwardRef(Typography)) (created by MissingImplementsApisEmptyState)
in p (created by ForwardRef(Typography))
in ForwardRef(Typography) (created by WithStyles(ForwardRef(Typography)))
in WithStyles(ForwardRef(Typography)) (created by EmptyState)
in div (created by ForwardRef(Grid))
in ForwardRef(Grid) (created by WithStyles(ForwardRef(Grid)))
in WithStyles(ForwardRef(Grid)) (created by EmptyState)
in div (created by ForwardRef(Grid))
in ForwardRef(Grid) (created by WithStyles(ForwardRef(Grid)))
in WithStyles(ForwardRef(Grid)) (created by EmptyState)
in div (created by ForwardRef(Grid))
in ForwardRef(Grid) (created by WithStyles(ForwardRef(Grid)))
in WithStyles(ForwardRef(Grid)) (created by EmptyState)
in EmptyState (created by MissingImplementsApisEmptyState)
in MissingImplementsApisEmptyState (created by Router)
in Router (at EntityPage.tsx:78)
in article (created by Content)
in Content (created by Layout)
in Layout (created by EntityPageLayout)
in div (created by Page)
in ThemeProvider (created by Page)
in Page (created by EntityPageLayout)
in EntityPageLayout (at EntityPage.tsx:64)
in ServiceEntityPage (at EntityPage.tsx:127)
in EntityPage (created by EntityPageSwitch)
in EntityPageSwitch (created by Router)
in EntityProvider (created by Router)
in Route (created by Router)
in Routes (created by Router)
in Router (at App.tsx:46)
in Route (at App.tsx:44)
in Routes (at App.tsx:42)
in div (created by SidebarPage)
in SidebarPage (at App.tsx:40)
in Route (created by AppRouter)
in Routes (created by AppRouter)
in Router (created by BrowserRouter)
in BrowserRouter (created by AppRouter)
in AppRouter (at App.tsx:39)
in CssBaseline (created by WithStyles(CssBaseline))
in WithStyles(CssBaseline) (created by AppThemeProvider)
in ThemeProvider (created by AppThemeProvider)
in AppThemeProvider (created by Provider)
in AppContextProvider (created by Provider)
in ApiProvider (created by Provider)
in Provider (at App.tsx:36)
in App (at src/index.tsx:6)
```
Co-authored-by: Peter Colapietro <petercolapietro@gmail.com>
* Allow application to register custom `AuthProviderFactory`. Refs #1984
* PR comments: Explicit exports
* Export `OAuth` specific types from the package
* Update documentation on how to use the interfaces
* Re-export from base `index.ts` as per ADR-004
* pass `providerId` as a parameter to `AuthFactory` instead of hardcoding
Co-authored-by: Govindarajan Nagarajan <govindarajan.nagarajan@zalando.de>
1. Don't use mkdocs in name of APIs or variables. It is an implementation detail and liable to change in future.
2. techDocsApi.getMetadata('mkdocs') and techDocsAPI.getMetadata('entity') should be two separate functions just because their responses differ in structure. They should also be type checked.
3. Use either 'techdocs' or 'TechDocs' consistently. 'techDocs' seems like an unnecessary third way to write TechDocs, which can be avoided.
4. Remove unused /plugins/techdocs-backend/src/service/metadata.ts file
* load filters from entities
* fix(search): compile possible filter options from available entities
* rename filter state and add text in case no filter can be applied
* TechDocs: Logger already prints the name of plugin
* TechDocs: Display a custom error message if provided
* TechDocs: throw custom error message if index.md is not present
* Language improvements. Thanks @freben
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Moustafa Baiou