silence some new ts squigglies in the editor (#3435)

packages/cli/src/lib/bundler/server.ts

@@ -60,7 +60,7 @@ export async function serveBundle(options: ServeOptions) {
     proxy: pkg.proxy,
   });
 
-  await new Promise((resolve, reject) => {
+  await new Promise<void>((resolve, reject) => {
     server.listen(port, url.hostname, (err?: Error) => {
       if (err) {
         reject(err);

packages/cli/src/lib/run.ts

@@ -102,7 +102,7 @@ export async function waitForExit(
     return;
   }
 
-  await new Promise((resolve, reject) => {
+  await new Promise<void>((resolve, reject) => {
     child.once('error', error => reject(error));
     child.once('exit', code => {
       if (code) {

packages/core-api/src/apis/implementations/OAuthRequestApi/MockOAuthApi.ts

@@ -31,7 +31,7 @@ export default class MockOAuthApi implements OAuthRequestApi {
   async triggerAll() {
     await Promise.resolve(); // Wait a tick to allow new requests to get forwarded
 
-    return new Promise(resolve => {
+    return new Promise<void>(resolve => {
       const subscription = this.authRequest$().subscribe(requests => {
         subscription.unsubscribe();
         Promise.all(requests.map(request => request.trigger())).then(() =>
@@ -44,7 +44,7 @@ export default class MockOAuthApi implements OAuthRequestApi {
   async rejectAll() {
     await Promise.resolve(); // Wait a tick to allow new requests to get forwarded
 
-    return new Promise(resolve => {
+    return new Promise<void>(resolve => {
       const subscription = this.authRequest$().subscribe(requests => {
         subscription.unsubscribe();
         requests.map(request => request.reject());

packages/core-api/src/apis/implementations/StorageApi/WebStorage.test.ts

@@ -63,7 +63,7 @@ describe('WebStorage Storage API', () => {
     const selectedKeyNextHandler = jest.fn();
     const mockData = { hello: 'im a great new value' };
 
-    await new Promise(resolve => {
+    await new Promise<void>(resolve => {
       storage.observe$<String>('correctKey').subscribe({
         next: (...args) => {
           selectedKeyNextHandler(...args);
@@ -93,7 +93,7 @@ describe('WebStorage Storage API', () => {
 
     storage.set('correctKey', mockData);
 
-    await new Promise(resolve => {
+    await new Promise<void>(resolve => {
       storage.observe$('correctKey').subscribe({
         next: (...args) => {
           selectedKeyNextHandler(...args);

packages/e2e-test/src/lib/helpers.ts

@@ -93,7 +93,7 @@ export function exitWithError(err: Error & { code?: unknown }) {
  */
 export function waitFor(fn: () => boolean, maxSeconds: number = 120) {
   let count = 0;
-  return new Promise((resolve, reject) => {
+  return new Promise<void>((resolve, reject) => {
     const handle = setInterval(() => {
       if (count++ > maxSeconds * 10) {
         reject(new Error('Timed out while waiting for condition'));
@@ -112,7 +112,7 @@ export async function waitForExit(child: ChildProcess) {
   if (child.exitCode !== null) {
     throw new Error(`Child already exited with code ${child.exitCode}`);
   }
-  await new Promise((resolve, reject) =>
+  await new Promise<void>((resolve, reject) =>
     child.once('exit', code => {
       if (code) {
         reject(new Error(`Child exited with code ${code}`));

packages/test-utils/src/testUtils/apis/StorageApi/MockStorageApi.test.ts

@@ -58,7 +58,7 @@ describe('WebStorage Storage API', () => {
     const selectedKeyNextHandler = jest.fn();
     const mockData = { hello: 'im a great new value' };
 
-    await new Promise(resolve => {
+    await new Promise<void>(resolve => {
       storage.observe$<String>('correctKey').subscribe({
         next: (...args) => {
           selectedKeyNextHandler(...args);
@@ -88,7 +88,7 @@ describe('WebStorage Storage API', () => {
 
     storage.set('correctKey', mockData);
 
-    await new Promise(resolve => {
+    await new Promise<void>(resolve => {
       storage.observe$('correctKey').subscribe({
         next: (...args) => {
           selectedKeyNextHandler(...args);

plugins/auth-backend/src/providers/microsoft/provider.ts

@@ -163,7 +163,7 @@ export class MicrosoftAuthProvider implements OAuthHandlers {
     });
   }
 
-  private getUserPhoto(accessToken: string): Promise<string> {
+  private getUserPhoto(accessToken: string): Promise<string | undefined> {
     return new Promise(resolve => {
       got
         .get('https://graph.microsoft.com/v1.0/me/photos/48x48/$value', {
@@ -184,7 +184,7 @@ export class MicrosoftAuthProvider implements OAuthHandlers {
             `Could not retrieve user profile photo from Microsoft Graph API: ${error}`,
           );
           // User profile photo is optional, ignore errors and resolve undefined
-          resolve();
+          resolve(undefined);
         });
     });
   }

plugins/catalog-backend/src/util/runPeriodically.ts

@@ -27,7 +27,7 @@
 export function runPeriodically(fn: () => any, delayMs: number): () => void {
   let cancel: () => void;
   let cancelled = false;
-  const cancellationPromise = new Promise(resolve => {
+  const cancellationPromise = new Promise<void>(resolve => {
     cancel = () => {
       resolve();
       cancelled = true;

plugins/scaffolder-backend/src/scaffolder/stages/templater/helpers.ts

@@ -66,7 +66,7 @@ export const runCommand = async ({
   args,
   logStream = new PassThrough(),
 }: RunCommandOptions) => {
-  await new Promise((resolve, reject) => {
+  await new Promise<void>((resolve, reject) => {
     const process = spawn(command, args);
 
     process.stdout.on('data', stream => {
@@ -109,7 +109,7 @@ export const runDockerContainer = async ({
   dockerClient,
   createOptions = {},
 }: RunDockerContainerOptions) => {
-  await new Promise((resolve, reject) => {
+  await new Promise<void>((resolve, reject) => {
     dockerClient.pull(imageName, {}, (err, stream) => {
       if (err) return reject(err);
       stream.pipe(logStream, { end: false });
@@ -120,6 +120,7 @@ export const runDockerContainer = async ({
   });
 
   const userOptions: UserOptions = {};
+  // @ts-ignore
   if (process.getuid && process.getgid) {
     // Files that are created inside the Docker container will be owned by
     // root on the host system on non Mac systems, because of reasons. Mainly the fact that

plugins/techdocs-backend/src/techdocs/stages/generate/helpers.ts

@@ -63,7 +63,7 @@ export async function runDockerContainer({
     );
   }
 
-  await new Promise((resolve, reject) => {
+  await new Promise<void>((resolve, reject) => {
     dockerClient.pull(imageName, {}, (err, stream) => {
       if (err) return reject(err);
       stream.pipe(logStream, { end: false });
@@ -119,7 +119,7 @@ export const runCommand = async ({
   options,
   logStream = new PassThrough(),
 }: RunCommandOptions) => {
-  await new Promise((resolve, reject) => {
+  await new Promise<void>((resolve, reject) => {
     const process = spawn(command, args, options);
 
     process.stdout.on('data', stream => {