paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 21 Packages Projects Releases Wiki Activity
27,295 Commits 1 Branch 0 Tags
b8884fd579e89187d293d6ff2dccc0557fcc6b08
Commit Graph

621 Commits

Author SHA1 Message Date
Ben Lambert 9943557a57 Merge pull request #11154 from angeliski/add-tasks-owner 
Add tasks owner
 2022-06-01 11:16:37 +02:00
Ben Lambert bd671d0696 Merge pull request #11732 from ivd-git/scaffolder-review-mask-bugfix-11687 
Make code work as documented. Review mask does not need 'show: true'.…
 2022-06-01 10:52:09 +02:00
blam 698c55f182 chore: code review changes 
Signed-off-by: blam <ben@blam.sh>
 2022-05-31 16:42:51 +02:00
Ingmar van Dijk b9ce08bbb8 Fix code style on MultistepJsonForm. Prettier check will pass now. 
Signed-off-by: Ingmar van Dijk <ingmar.van.dijk@philips.com>
 2022-05-31 16:17:25 +02:00
Ingmar van Dijk 115214b719 Make code work as documented. Review mask does not need 'show: true'. (#11687) 
Signed-off-by: Ingmar van Dijk <ingmar.van.dijk@philips.com>
 2022-05-31 16:16:19 +02:00
blam 69b737c568 Merge remote-tracking branch 'origin' into add-tasks-owner 
* origin: (56 commits)
  scaffolder-backend: fix merge conflict in router
  scaffolder: disable global save button in template editor if no files are dirty
  scaffolder: update API report
  scaffolder: remove unnecessary TemplateFileSystemAccess interface
  scaffolder: wrap dry-run log body in an outer object
  scaffolder: fix life
  scaffolder: make dry-run secrets optional to match task execution
  scaffolder: rename dry-run contents -> directoryContents
  scaffolder-backend: refactor actions to use serializeDirectoryContents
  scaffolder-backend: clarifying comment about done
  scaffolder-backend: add dry-run request body validation
  scaffolder-backend: validate dry-run template input
  sfaffolder: switch /v2/dryrun to /v2/dry-run
  scaffolder,scaffolder-backend: fix API reports
  scaffolder: fix dryRun implementation in ScaffolderClient
  scaffolder: add test for TemplateEditorBrowser
  scaffolder: add test for TemplateEditorPage
  scaffolder: add test for DryRunResultsView
  scaffolder: memo methods in DryRunProvider
  scaffolder: add DryRunResultsList tests
  ...

Signed-off-by: blam <ben@blam.sh>
 2022-05-31 14:58:51 +02:00
Patrik Oldsberg 139f8f08a2 scaffolder: disable global save button in template editor if no files are dirty 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:25 +02:00
Patrik Oldsberg a2490f64fe scaffolder: remove unnecessary TemplateFileSystemAccess interface 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:25 +02:00
Patrik Oldsberg 73e427c405 scaffolder: wrap dry-run log body in an outer object 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:25 +02:00
Patrik Oldsberg b817af39ad scaffolder: make dry-run secrets optional to match task execution 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:25 +02:00
Patrik Oldsberg c7a5d8d7ae scaffolder: rename dry-run contents -> directoryContents 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:24 +02:00
Patrik Oldsberg 36c39f9b42 sfaffolder: switch /v2/dryrun to /v2/dry-run 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:24 +02:00
Patrik Oldsberg b622410ef0 scaffolder,scaffolder-backend: fix API reports 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:24 +02:00
Patrik Oldsberg 636dc85781 scaffolder: fix dryRun implementation in ScaffolderClient 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:24 +02:00
Patrik Oldsberg d59ec5c6d5 scaffolder: add test for TemplateEditorBrowser 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:24 +02:00
Patrik Oldsberg 01db4019e0 scaffolder: add test for TemplateEditorPage 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:24 +02:00
Patrik Oldsberg 71228274ae scaffolder: add test for DryRunResultsView 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:24 +02:00
Patrik Oldsberg e48ca034e9 scaffolder: memo methods in DryRunProvider 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:24 +02:00
Patrik Oldsberg 4b839c4f02 scaffolder: add DryRunResultsList tests 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:24 +02:00
Patrik Oldsberg 88b81c3e6f scaffolder: add tests for DryRunResults 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:24 +02:00
Patrik Oldsberg 05b6044399 scaffolder: memo DryRunContext value 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:24 +02:00
Patrik Oldsberg ace95e391c scaffolder: flatten TemplateEditorPage structure 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:24 +02:00
Patrik Oldsberg 289d349199 scaffolder: always show file reload in TemplateEditorTextArea 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:23 +02:00
Patrik Oldsberg f7805dfea8 scaffolder: add wrapper to TemplateEditorForm to handle overflow 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:23 +02:00
Patrik Oldsberg c98cfa0e6c scaffolder: refactor TemplateFormPreviewer to use common components 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:23 +02:00
Patrik Oldsberg 3c87f60481 scaffolder: tweak names of TemplateEditor components 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:23 +02:00
Patrik Oldsberg 6758e83662 scaffolder: extract TemplateEditorBrowser 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:23 +02:00
Patrik Oldsberg 5146bc96fc scaffolder: extract TemplateEditorForm 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:23 +02:00
Patrik Oldsberg a788dacc73 scaffolder: extract TemplateEditorTextArea 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:23 +02:00
Patrik Oldsberg 48307fbf0d scaffolder: remove unused DirectoryLoader 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:23 +02:00
Patrik Oldsberg 5d63d15dbf scaffolder: extract FileBrowser 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:23 +02:00
Patrik Oldsberg 5edc82d02a scaffolder: extract DryRunResultsView + refactor DryRunResults 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:23 +02:00
Patrik Oldsberg 483aa3a47b scaffolder: extract DryRunResultsList 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:23 +02:00
Patrik Oldsberg bb95aca5aa scaffolder: extract DryRunResultsSplitView 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:23 +02:00
Patrik Oldsberg 7e41a70dee scaffolder: move TemplateEditorDryRunResults to subdir 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:23 +02:00
Patrik Oldsberg 633afdd01b scaffolder: fix codemirror import 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:22 +02:00
Patrik Oldsberg 93af1ae48e scaffolder: move TemplateEditor components into subdirectory 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:22 +02:00
Patrik Oldsberg 84e3c67ae3 scaffolder: fix width for dry run results view side pane 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:22 +02:00
Patrik Oldsberg a9e587c761 scaffolder: fix template dry run results panel not expanding on first show 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:22 +02:00
Patrik Oldsberg dc1d67fc5b scaffolder: tweak TemplateEditor error panel 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:22 +02:00
Patrik Oldsberg d989e0c203 scaffolder: remove mock editor data 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:22 +02:00
Patrik Oldsberg a818ce53a7 scaffolder: tweak TemplateEditor error display 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:22 +02:00
Patrik Oldsberg 7c6ceb2d32 scaffolder: hook up template editor buttons + floating text area buttons and hotkey 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:22 +02:00
Patrik Oldsberg df4497ecd7 scaffolder: initial e2e editor + dry-run 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:22 +02:00
Patrik Oldsberg 16f11352ab scaffolder: allow tweaking of the MultiStepJsonForm finish button label 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:22 +02:00
Patrik Oldsberg c3a24968b3 scaffolder: add filesystem access helpers 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-05-31 13:24:22 +02:00
blam 1cd1c184ee chore: reworking the api to wrap up in an object 
Signed-off-by: blam <ben@blam.sh>
 2022-05-31 12:03:02 +02:00
blam 61d31317a1 chore: fixing context menu 
Signed-off-by: blam <ben@blam.sh>

Signed-off-by: blam <ben@blam.sh>
 2022-05-31 12:03:01 +02:00
blam ee63f03e91 chore: fixing typescript 
Signed-off-by: blam <ben@blam.sh>
 2022-05-31 12:03:01 +02:00
blam 2de8c51462 chore: fixing up the tests for the scaffolder tasks now the API has changed 
Signed-off-by: blam <ben@blam.sh>
 2022-05-31 12:03:01 +02:00