Merge pull request #11732 from ivd-git/scaffolder-review-mask-bugfix-11687

Make code work as documented. Review mask does not need 'show: true'.…
2022-06-01 10:52:09 +02:00
parent 116d83acec a83465692e
commit bd671d0696
3 changed files with 8 additions and 4 deletions
@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-scaffolder': patch
+---
+
+Fixes review mask in `MultistepJsonForm` to work as documented. `show: true` no longer needed when mask is set.
@@ -41,7 +41,6 @@ describe('MultistepJsonForm', () => {
            type: 'string',
            'ui:backstage': {
              review: {
-                show: true,
                mask: '******',
              },
            },
@@ -95,12 +95,12 @@ export function getReviewData(formData: Record<string, any>, steps: Step[]) {
      }

      const review = uiSchema['ui:backstage'].review as JsonObject;
-      if (!review.show) {
+      if (review.mask) {
+        reviewData[key] = review.mask;
        continue;
      }

-      if (review.mask) {
-        reviewData[key] = review.mask;
+      if (!review.show) {
        continue;
      }
      reviewData[key] = formData[key];