Commit Graph

158 Commits

Author SHA1 Message Date
Fredrik Adelöw 811ff0cddc implement analytics too
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2024-10-11 09:48:52 +02:00
Fredrik Adelöw 9cc7dd6cfd implement the beginnings of mockApis
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2024-10-08 17:58:34 +02:00
blam 4a5ba19344 chore: removals
Signed-off-by: blam <ben@blam.sh>
2024-09-18 18:53:39 +02:00
Andre Wanlin 9adc552602 Refactoring based on feedback
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
2024-09-10 15:05:42 -05:00
Andre Wanlin 32fce06e89 Added missing items to overridableComponents
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
2024-09-10 15:05:42 -05:00
Fredrik Adelöw d76cc2974f Merge pull request #26396 from backstage/renovate/react-monorepo
chore(deps): update dependency @types/react to v18.3.5
2024-09-06 14:57:54 +02:00
Fredrik Adelöw dbbd93ec7f fixup
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2024-09-06 10:49:28 +02:00
blam 1ac573b4f3 chore: smol refactor
Signed-off-by: blam <ben@blam.sh>
2024-09-03 07:59:02 +02:00
Patrik Oldsberg 00b9e8c010 update test snapshots for new structure of ExtensionDefinition
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-08-27 10:39:45 +02:00
Patrik Oldsberg e6e488cf20 frontend-test-utils: remove render method
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-08-27 09:39:08 +02:00
Fredrik Adelöw f26ff99a2f fixup
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2024-08-23 14:42:50 +02:00
Fredrik Adelöw dae74b0d05 Merge pull request #25611 from RikClaessens/use-search-icon
Update the SearchBar to make use of the useApp hook to retrieve the search icon specified in the createApp call
2024-08-21 10:47:05 +02:00
Patrik Oldsberg d0501bb8c2 search-react: removed deprecated extension creators
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-08-20 12:15:09 +02:00
blam 4c39af8902 feat: small refactor for the search package
Co-authored-by: Fredrik Adelöw <freben@users.noreply.github.com>
Signed-off-by: blam <ben@blam.sh>
2024-08-15 09:59:55 +02:00
blam 8f8519d94e feat: implement search
Signed-off-by: blam <ben@blam.sh>
2024-08-15 09:59:55 +02:00
Rik Claessens d6ef48f201 Merge branch 'master' into use-search-icon 2024-08-07 14:59:34 +02:00
Patrik Oldsberg 31bfc4417f frontend-plugin-api: update extension data ref declaration to allow embedding of ID in type
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-07-22 10:20:38 +02:00
Rik Claessens f9011ac3d4 Wrap storybook components for SearchBar and SearchBarAutocomplete in wrapInTestApp
Signed-off-by: Rik Claessens <rhmclaessens@gmail.com>
2024-07-13 14:07:54 +02:00
Rik Claessens e460cbb027 Replace renderWithEffects with renderInTestApp to fix all existing tests
Signed-off-by: Rik Claessens <rhmclaessens@gmail.com>
2024-07-13 11:42:38 +02:00
Rik Claessens 85095afd82 Add test for checking if the SearchBar renders the provided custom search icon
Signed-off-by: Rik Claessens <rhmclaessens@gmail.com>
2024-07-13 11:40:40 +02:00
Rik Claessens 960b292c68 Replace renderWithEffects with renderInTestApp to fix all existing tests
Signed-off-by: Rik Claessens <rhmclaessens@gmail.com>
2024-07-13 11:31:09 +02:00
Rik Claessens 9d66d8cd90 Make use of the useApp hook to retrieve search icon
Signed-off-by: Rik Claessens <rhmclaessens@gmail.com>
2024-07-12 23:28:36 +02:00
Juan Pablo Garcia Ripa 8d50bd34fe add miu import rules to Search-react
Signed-off-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
2024-04-13 22:04:44 +02:00
Tomasz Szuba e8f026a300 Use esm exports from react-use library
Signed-off-by: Tomasz Szuba <tszuba@box.com>
2024-03-19 19:53:04 +00:00
Emma Indal 6f280fa01a fix search issue analytics tracking
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2023-12-18 16:24:45 +01:00
Patrik Oldsberg 58141224d3 plugins: update all other plugins to fit new frontend system naming patterns
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-12-13 19:31:28 +01:00
Patrik Oldsberg 8f5d6c1fbf frontend-plugin-api: wrap resolved extension inputs in an object
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Vincenzo Scamporlino <vincenzos@spotify.com>
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: Philipp Hugenroth <philipph@spotify.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-11-28 19:17:48 +01:00
Patrik Oldsberg 818eea4925 frontend-test-utils: updates to work with new extension IDs
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-11-28 16:24:49 +01:00
Patrik Oldsberg 36c94b8462 plugins: refactor DI extension IDs
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-11-28 16:24:49 +01:00
Patrik Oldsberg 792983e167 refactor to forward node to ExtensionBoundary
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-11-22 13:07:40 +01:00
Patrik Oldsberg 326a9e40e1 frontend-test-utils: switch createExtensionTester render to be sync
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Philipp Hugenroth <philipph@spotify.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-11-15 13:43:33 +01:00
Patrik Oldsberg 37f4f98ba2 search-react: use frontend-test-utils
Co-authored-by: Vincenzo Scamporlino <vincenzos@spotify.com>
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-11-15 12:30:41 +01:00
Fredrik Adelöw 77c1e227f6 test with analytics api only in the dedicated test
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2023-11-09 09:37:51 +01:00
Fredrik Adelöw f48cde800a fix the analytics flakiness in search
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2023-11-07 14:09:10 +01:00
Patrik Oldsberg 897c787f17 Merge pull request #20853 from backstage/rugvip/factory
frontend-plugin-api: return output from extension factories instead
2023-10-27 16:41:53 +02:00
Ben Lambert 9383ba07c9 Merge pull request #20615 from acierto/configure-template
Make it possible to define control buttons text (Back, Create, Review) per template
2023-10-27 15:14:19 +02:00
Patrik Oldsberg 77f009b35d frontend-plugin-api: return output from extension factories instead
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-10-27 14:57:48 +02:00
Patrik Oldsberg a539643cba search-react: minor search bar analytics refactor
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-10-24 14:19:39 +02:00
Bogdan Nechyporenko 27b3963e03 Fix for flaky SearchContext.test.tsx
Signed-off-by: Bogdan Nechyporenko <bnechyporenko@bol.com>
2023-10-24 12:57:06 +02:00
Patrik Oldsberg f75caf9f3d search-react: fix search bar race
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-10-20 12:59:43 +02:00
Camila Belo 66af240ea6 refactor(frontend-plugin-api): merge boundary and suspense components
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2023-10-19 14:54:35 +02:00
Camila Belo cca1afc547 refactor(search): restore inline attachment
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2023-10-19 13:57:54 +02:00
Camila Belo b51919e3eb refactor(search-react): use extension boundary and suspense
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2023-10-19 12:33:28 +02:00
Patrik Oldsberg 7e045eb0c3 remove act wrapping of userEvent
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-10-18 09:37:04 +02:00
Patrik Oldsberg 0696ef1a34 replace usages of await act(async () => {}) with waitFor
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-10-18 09:37:04 +02:00
Patrik Oldsberg bfee94f0c5 search-react: test fix for RTL 14
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-10-18 09:37:04 +02:00
Patrik Oldsberg 80a79cc1e7 plugins: rtl 13 fixes for tests
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-10-18 09:37:03 +02:00
Patrik Oldsberg 0935b0d60f rtl 13 fixes for tests with type issues
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-10-18 09:37:03 +02:00
Patrik Oldsberg d60fbcb553 remove usages of @testing-library/react-hooks
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-10-18 09:37:03 +02:00
Patrik Oldsberg 0296f272b4 type fixes for React 18
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-10-13 11:24:00 +02:00