frontend-test-utils: switch createExtensionTester render to be sync

Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Philipp Hugenroth <philipph@spotify.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>

packages/frontend-plugin-api/src/components/ExtensionBoundary.test.tsx

@@ -54,9 +54,7 @@ describe('ExtensionBoundary', () => {
     const TextComponent = () => {
       return <p>{text}</p>;
     };
-    await createExtensionTester(
-      wrapInBoundaryExtension(<TextComponent />),
-    ).render();
+    createExtensionTester(wrapInBoundaryExtension(<TextComponent />)).render();
     await waitFor(() => expect(screen.getByText(text)).toBeInTheDocument());
   });
 
@@ -65,9 +63,7 @@ describe('ExtensionBoundary', () => {
     const ErrorComponent = () => {
       throw new Error(error);
     };
-    await createExtensionTester(
-      wrapInBoundaryExtension(<ErrorComponent />),
-    ).render();
+    createExtensionTester(wrapInBoundaryExtension(<ErrorComponent />)).render();
     await waitFor(() => expect(screen.getByText(error)).toBeInTheDocument());
   });
 
@@ -84,7 +80,7 @@ describe('ExtensionBoundary', () => {
       return null;
     };
 
-    await createExtensionTester(
+    createExtensionTester(
       wrapInBoundaryExtension(
         <TestApiProvider apis={[[analyticsApiRef, analyticsApiMock]]}>
           <AnalyticsComponent />

packages/frontend-test-utils/api-report.md

@@ -25,7 +25,7 @@ export class ExtensionTester {
     },
   ): ExtensionTester;
   // (undocumented)
-  render(options?: { config?: JsonObject }): Promise<RenderResult>;
+  render(options?: { config?: JsonObject }): RenderResult;
 }
 
 // (No @packageDocumentation comment for this package)

packages/frontend-test-utils/src/app/createExtensionTester.test.tsx

@@ -24,7 +24,7 @@ import { createExtensionTester } from './createExtensionTester';
 
 describe('createExtensionTester', () => {
   it('should render a simple extension', async () => {
-    await createExtensionTester(
+    createExtensionTester(
       createExtension({
         id: 'test',
         attachTo: { id: 'ignored', input: 'ignored' },
@@ -37,7 +37,7 @@ describe('createExtensionTester', () => {
   });
 
   it('should render an extension even if disabled by default', async () => {
-    await createExtensionTester(
+    createExtensionTester(
       createExtension({
         id: 'test',
         attachTo: { id: 'ignored', input: 'ignored' },
@@ -51,7 +51,7 @@ describe('createExtensionTester', () => {
   });
 
   it("should fail to render an extension that doesn't output a react element", async () => {
-    await expect(
+    expect(() =>
       createExtensionTester(
         createExtension({
           id: 'test',
@@ -61,7 +61,7 @@ describe('createExtensionTester', () => {
           factory: () => ({ path: '/foo' }),
         }),
       ).render(),
-    ).rejects.toThrow(
+    ).toThrow(
       "Failed to instantiate extension 'core', input 'root' did not receive required extension data 'core.reactElement' from extension 'test'",
     );
   });

packages/frontend-test-utils/src/app/createExtensionTester.ts

@@ -49,7 +49,7 @@ export class ExtensionTester {
     return this;
   }
 
-  async render(options?: { config?: JsonObject }): Promise<RenderResult> {
+  render(options?: { config?: JsonObject }): RenderResult {
     const { config = {} } = options ?? {};
 
     const [subject, ...rest] = this.#extensions;

plugins/search-react/src/alpha.test.tsx

@@ -147,7 +147,7 @@ describe('createSearchResultListItemExtension', () => {
       },
     });
 
-    await createExtensionTester(SearchPageExtension)
+    createExtensionTester(SearchPageExtension)
       .add(TechDocsSearchResultItemExtension, {
         // TODO(Rugvip): We need to make the config input type available for use here
         config: {