Commit Graph

8217 Commits

Author SHA1 Message Date
Himanshu Mishra 8e083f41f3 fix(scaffolder): Allow user to retry creating a new software without refreshing the page
This is more of a bug fix than a new feature. The commit fixes 2 problems mainly.

1. When user clicks the close button on the JobStatusModal, it does not set the `modalOpen` state of its parent component. Thus, even after closing, JobStatusModal still persists in DOM, and modalOpen is still set to true. That is why, retrying by clicking on "Submit" again does not open the modal.

2. The useJobPolling hook does not consider starting the timer again when Job changes. Even if jobId changes, the logic to set `shouldBeRunningInterval` still uses a previous value of `currentJob` since it was never reset since the timer stopped. Using a effect hook and having jobId as a dependency to reset currentJob is the way to fix this.
2020-12-29 00:24:27 +01:00
Himanshu Mishra ede29f55c7 Merge pull request #3813 from backstage/orkohunter/use-@backstage-integration 2020-12-28 21:45:35 +01:00
Himanshu Mishra 8804e89811 techdocs: Add changeset for @backstage/integration changes 2020-12-28 21:18:18 +01:00
Himanshu Mishra c91e4d6b04 techdocs: Use @backstage/integration for scm tokens and request options 2020-12-28 21:08:54 +01:00
Himanshu Mishra bd3bc94ff8 Merge pull request #3799 from keshann93/plugins/techdocs 2020-12-28 20:52:53 +01:00
Tim ad821a1463 Merge pull request #3855 from sisidra/sisidra/positive-vibes-in-cost-insights
Introduce slight bias towards positive trend in cost insights mock data
2020-12-28 08:42:46 -07:00
Tim 00867c1dc9 Merge pull request #3853 from sisidra/sisidra/doc-fix-durationts
Fix parameter name in docstring for duration#inclusiveStartDateOf
2020-12-28 08:42:26 -07:00
Fredrik Adelöw 72108829ce Merge pull request #3822 from fidelcoria/fix-login-race
fix(auth): race condition between loginPopup and authFlowHelpers
2020-12-28 15:55:22 +01:00
Patrik Oldsberg b23bc9638f Merge pull request #3854 from backstage/rugvip/flat
core-api: rename BackstageRoutes to FlatRoutes
2020-12-28 13:36:39 +01:00
Patrik Oldsberg b2195fc06c Merge pull request #3844 from backstage/mob/dev-utils
dev-utils: add addPage for use with composability API + EntityGridItem to easily create different card test cases
2020-12-28 12:43:08 +01:00
Fredrik Adelöw f36db36cc5 Merge pull request #3852 from backstage/freben/linked-win32
cli: fix LinkedPackageResolvePlugin windows tests
2020-12-28 12:18:54 +01:00
Fredrik Adelöw 0574a27b7c cli: fix windows tests 2020-12-28 11:43:25 +01:00
Mārtiņš Kalvāns 37b28bad44 Introduce slight bias towards positive trend in cost insights mock data 2020-12-28 11:34:56 +01:00
Patrik Oldsberg 5b6533eb76 core-api: rename BackstageRoutes to FlatRoutes 2020-12-28 11:19:52 +01:00
Patrik Oldsberg 246281b6e3 Merge pull request #3840 from backstage/rugvip/depr
core-api: deprecate RouteRef path and remove deprecated createSubRoute
2020-12-28 11:15:08 +01:00
Patrik Oldsberg 1f26325bee Merge pull request #3845 from backstage/mob/entpro
catalog: rename EntityProvider to EntityLoaderProvider, and add new EntityProvider
2020-12-28 11:14:02 +01:00
Patrik Oldsberg 63f40032ca Update plugins/catalog/src/hooks/useEntity.ts
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
2020-12-28 11:13:50 +01:00
Mārtiņš Kalvāns cff6a9e70f Fix parameter name in docstring for duration#inclusiveStartDateOf 2020-12-28 10:38:49 +01:00
Fredrik Adelöw 84aa6f4a00 Merge pull request #3849 from erikxiv/fix/token-expiration-bug
fix: id token expiration in s, not ms
2020-12-27 11:32:28 +01:00
Erik Larsson 4975224d8e Adjust test 2020-12-27 10:52:18 +01:00
Erik Larsson cc046682e2 Add changeset 2020-12-27 09:55:19 +01:00
Erik Larsson d63cc1fe52 fix: token expiration in s, not ms 2020-12-27 09:45:06 +01:00
Patrik Oldsberg 696b8ce74a Create loud-days-breathe.md 2020-12-23 18:46:42 +01:00
Patrik Oldsberg 87c0c53c2f Create polite-glasses-occur.md 2020-12-23 18:45:43 +01:00
Patrik Oldsberg 920b5a4f54 dev-utils: add a small label with the entity name to EntityGridItems 2020-12-23 18:34:43 +01:00
Patrik Oldsberg 36ffbd71b7 dev-utils: add EntityGridItem for easily displaying various entity cards
Co-authored-by: blam <ben@blam.sh>
2020-12-23 18:34:42 +01:00
Patrik Oldsberg 4f467143c3 dev-utils: use dev index module as root for hot reloading
Co-authored-by: blam <ben@blam.sh>
2020-12-23 18:34:42 +01:00
Patrik Oldsberg 91518a253f dev-utils: add .registerPage for use with extensions
Co-authored-by: blam <ben@blam.sh>
2020-12-23 18:34:42 +01:00
Patrik Oldsberg d814e3b88e catalog: rename EntityProvider to EntityLoaderProvider, and add new EntityProvider
Co-authored-by: blam <ben@blam.sh>
2020-12-23 18:33:46 +01:00
Adam Harvey 3d3c9bd5e9 Merge pull request #3841 from adamdmharvey/improve-codeql
build: Improve CodeQL flow
2020-12-23 12:21:38 -05:00
Fidel Coria 7dfcdc1720 reduce close timeout to 100 ms 2020-12-23 11:15:36 -06:00
Ben Lambert ebd8076f8e Merge pull request #3828 from iamrajiv/master
Fixed category labels in Plugin Marketplace
2020-12-23 18:00:12 +01:00
Adam Harvey b721eab127 Speed up some PRs with paths-ignore 2020-12-23 10:18:52 -05:00
Adam Harvey 51f4005f3a Remove unnecessary step 2020-12-23 10:12:20 -05:00
Patrik Oldsberg 1e7b01668d Merge pull request #3830 from backstage/mob/entity-compose
catalog: add new composability components and extensions
2020-12-23 14:43:57 +01:00
Patrik Oldsberg 0f0e7a94f1 Merge pull request #3826 from backstage/mob/br
core-api: add BackstageRoutes
2020-12-23 14:43:14 +01:00
Patrik Oldsberg 86c3c652a8 changeset: add changeset for core-api RouteRef deprecations 2020-12-23 14:32:04 +01:00
Patrik Oldsberg 99205ec625 core-api: use typescript workaround for using private constructor instead of a runtime one 2020-12-23 14:29:13 +01:00
Patrik Oldsberg 4b896485e4 core-api: deprecate RouteRef path and remove deprecated createSubRoute 2020-12-23 13:56:24 +01:00
Himanshu Mishra d17bd3068d Merge pull request #3545 from backstage/orkohunter/create-github-releases
Create new GitHub release when a new tag is created
2020-12-23 13:06:34 +01:00
Adam Harvey 8509fc2ff3 Merge pull request #3832 from adamdmharvey/win-discord
build: Change Windows master build to use raw Discord webhook
2020-12-22 19:59:12 -05:00
Fidel Coria 29b4056f2c delay window close by 200 ms 2020-12-22 16:03:21 -06:00
Fidel Coria 0836691020 Revert "eliminate racey code"
This reverts commit 907fac9d92.
2020-12-22 15:44:42 -06:00
Patrik Oldsberg 4c7be88707 Merge pull request #3829 from backstage/adamdmharvey/plugin-typo
Fix PagerDuty plugin name in marketplace
2020-12-22 22:03:38 +01:00
Patrik Oldsberg d2d906d419 catalog: export EntitySwitch component and conditions 2020-12-22 21:42:26 +01:00
Patrik Oldsberg f56e18a878 Apply suggestions from code review
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
2020-12-22 21:39:45 +01:00
Patrik Oldsberg 7e0b8cac55 changeset: add changeset for new catalog composability components 2020-12-22 21:39:45 +01:00
Patrik Oldsberg b0e2e0f1e4 catalog: fix EntityLayout TabbedLayout route path matching
Co-authored-by: blam <ben@blam.sh>
2020-12-22 21:39:45 +01:00
Patrik Oldsberg c199963a08 catalog: gather all mount points beneath EntityLayout Routes
Co-authored-by: blam <ben@blam.sh>
2020-12-22 21:39:45 +01:00
Patrik Oldsberg 2686bdb3d6 catalog: add EntityLayout
Co-authored-by: blam <ben@blam.sh>
2020-12-22 21:39:44 +01:00