Commit Graph

652 Commits

Author SHA1 Message Date
Andrew Ellis 6cf48c6098 feat(plugin-scaffolder-backend): add defaultCommitMessage config option
Signed-off-by: Andrew Ellis <awellis89@gmail.com>
2021-07-29 15:28:22 -06:00
Andrea Falzetti 8db7ea4c2f docs: add api-reports
Signed-off-by: Andrea Falzetti <afalzetti@gmail.com>
2021-07-21 18:34:40 +01:00
Andrea Falzetti 8fb0874dd4 refactor: use repoUrl
Signed-off-by: Andrea Falzetti <afalzetti@gmail.com>
2021-07-21 16:53:52 +01:00
Andrea Falzetti f928a8f9bf chore: remove comment
Signed-off-by: Andrea Falzetti <afalzetti@gmail.com>
2021-07-21 16:53:22 +01:00
Andrea Falzetti 2ca8855b0d fix: remove ctx.token
Signed-off-by: Andrea Falzetti <afalzetti@gmail.com>
2021-07-21 16:53:22 +01:00
Yogesh Lonkar a370ecab04 fix unit test
Signed-off-by: Yogesh Lonkar <yogesh@lonkar.org>
Signed-off-by: Andrea Falzetti <afalzetti@gmail.com>
2021-07-21 16:53:21 +01:00
Andrea Falzetti c914db284f feat(scaffolder): add gha dispatch workflow action
Signed-off-by: Andrea Falzetti <afalzetti@gmail.com>
2021-07-21 16:53:21 +01:00
blam 2bffb18859 chore: run prettier on ugly document
Signed-off-by: blam <ben@blam.sh>
2021-07-15 12:34:55 +02:00
blam a0149f0228 chore: code review comments
Signed-off-by: blam <ben@blam.sh>
2021-07-15 12:22:12 +02:00
blam df7c9243d3 chore: use the cookiecutter templater library
Signed-off-by: blam <ben@blam.sh>
2021-07-15 12:11:06 +02:00
Brian Fletcher 11b07616fa wait until response is flushed before unsubscribing from broker
I am not sure why this works, but it seems to. I have been trying to
enable the scaffolder and found that when I view a task in progress or
complete that the task just sits with the text "Waiting for logs...".

This is a hunch.

Signed-off-by: Brian Fletcher <brian@roadie.io>
2021-07-14 09:09:58 +01:00
Ben Lambert 7a6a3586ac Merge pull request #6406 from backstage/joeporpeglia/github-pull-request-fix
Scaffolder: Fix repository inputs for publish:github:pull-request action
2021-07-13 14:03:28 +02:00
OscarDHdz 84d329e2a6 Scaffolder: Add handlebar 'eq' helper
Signed-off-by: OscarDHdz <v-ohernandez@expediagroup.com>
2021-07-09 12:13:15 -05:00
Joe Porpeglia 96fc276989 Fix repository inputs for githubPullRequest publish action
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2021-07-08 14:26:29 -04:00
Mike Lewis 099ea5e2d4 Merge remote-tracking branch 'origin/master' into mob/nunjucks-renderer
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-07-07 16:07:07 +01:00
Rogerio Angeliski 75b3d3d981 fix runCommand export
Signed-off-by: Rogerio Angeliski <angeliski@hotmail.com>
2021-07-07 09:34:04 -03:00
Mike Lewis 13d9940cde scaffolder: remove completed TODO in fetch:template
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-07-07 13:22:44 +01:00
Mike Lewis b4035aa463 scaffolder: tweak test description in fetch:template suite
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-07-07 13:21:24 +01:00
Rogerio Angeliski 944640535a update with PR comments
Signed-off-by: Rogerio Angeliski <angeliski@hotmail.com>
2021-07-07 08:58:41 -03:00
Rogerio Angeliski c5e81eab43 refactor to a isolated module
Signed-off-by: Rogerio Angeliski <angeliski@hotmail.com>
2021-07-07 08:58:36 -03:00
Rogerio Angeliski 7a3ad92b52 feat: added rails templater to scaffolder-backend
Signed-off-by: Rogerio Angeliski <angeliski@hotmail.com>
2021-07-07 08:55:57 -03:00
Mike Lewis 56b61c2bc0 scaffolder: prefix input values in fetch:template templates
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-07-07 11:26:00 +01:00
Mike Lewis 51513c6420 scaffolder: fix use of path.join in fetch:template tests
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-07-07 11:20:10 +01:00
Mike Lewis 886844aa30 scaffolder: platform-agnostic path joining in fetch:template test suite
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-07-07 11:00:14 +01:00
blam 8e183acc9c chore: code review comments
Signed-off-by: blam <ben@blam.sh>
2021-07-07 11:26:02 +02:00
blam fd5ec6d304 chore: some api-docs changed
Signed-off-by: blam <ben@blam.sh>
2021-07-07 11:25:38 +02:00
blam 2ed57f31c7 chore: write some tests for the cookiecutter templater
Signed-off-by: blam <ben@blam.sh>
2021-07-07 11:25:38 +02:00
blam b658d33944 chore: added some tests for cookiecutter but they need re-writing
Signed-off-by: blam <ben@blam.sh>
2021-07-07 11:25:38 +02:00
blam 2529ec28a6 chore: fixing all tests
Signed-off-by: blam <ben@blam.sh>
2021-07-07 11:25:38 +02:00
blam 4c689b0fae chore: making the failing test pass because of parameter validation
Signed-off-by: blam <ben@blam.sh>
2021-07-07 11:25:37 +02:00
blam 70bb2a711f chore: fix up some code review comments
Signed-off-by: blam <ben@blam.sh>
2021-07-07 11:25:37 +02:00
blam a41b024a0f feat: removing the last parts of v1alpha1 and fixing up TypeScript
Signed-off-by: blam <ben@blam.sh>
2021-07-07 11:25:37 +02:00
blam 18660e9337 chore: fixing merge conflict
Signed-off-by: blam <ben@blam.sh>
2021-07-07 11:25:37 +02:00
blam 6a09ed555d breaking: removing alphav1 support for templates
Signed-off-by: blam <ben@blam.sh>
2021-07-07 11:25:37 +02:00
Chase Rutherford-Jenkins 3c19f1230f update tests
Signed-off-by: Chase Rutherford-Jenkins <chaseajen@users.noreply.github.com>
2021-07-06 21:15:14 -05:00
Chase Rutherford-Jenkins b1aca39abe incorporate naming feedback; add tests
Signed-off-by: Chase Rutherford-Jenkins <chaseajen@users.noreply.github.com>
2021-07-06 20:51:22 -05:00
Chase Rutherford-Jenkins 921e3ca569 use configured git author in scaffolder actions
Co-authored-by: Himanshu Mishra <himanshu@orkohunter.net>
Signed-off-by: Chase Rutherford-Jenkins <chaseajen@users.noreply.github.com>
2021-07-06 20:51:01 -05:00
Mike Lewis b40370272b scaffolder: remove unused import in fetch:template
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-07-06 15:42:22 +01:00
Mike Lewis c22fc45ffa scaffolder: use resolveSafeChildPath in fetch:template
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-07-06 15:30:04 +01:00
Mike Lewis 9d759702b1 docs: update docs to refer to new fetch:template action
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-07-06 15:07:37 +01:00
Himanshu Mishra 6aeb2b93de fetch:template - test binary files are copied over
Signed-off-by: Himanshu Mishra <himanshu@orkohunter.net>
2021-07-06 15:48:14 +02:00
Himanshu Mishra f6eff971cb fetch:template - rename isTemplated to shouldCopyWithoutRender
(fix logging bug) and add test todo

Co-authored-by: Mike Lewis <mtlewis@users.noreply.github.com>
Signed-off-by: Himanshu Mishra <himanshu@orkohunter.net>
2021-07-06 14:51:58 +02:00
Himanshu Mishra 5f7e7db19d fetch:template - binary files should be copied to output path as-is
Co-authored-by: Mike Lewis <mtlewis@users.noreply.github.com>
Signed-off-by: Himanshu Mishra <himanshu@orkohunter.net>
2021-07-06 14:47:53 +02:00
Himanshu Mishra a8c83700eb fetch:template - skip running templater on binary files
Co-authored-by: Mike Lewis <mtlewis@users.noreply.github.com>
Signed-off-by: Himanshu Mishra <himanshu@orkohunter.net>
2021-07-06 13:51:59 +02:00
Mike Lewis ef07bce298 scaffolder: improve logging in fetch:template
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-07-06 11:16:59 +02:00
Mike Lewis b4680036b6 scaffolder: adjust case of cookieCutterCompat flag in fetch:template
Realized that `cookiecutter` is more idiomatic than `cookieCutter`,
so renamed the `cookieCutterCompat` flag on the new `fetch:template`
action to `cookiecutterCompat`.

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-07-06 11:16:59 +02:00
Mike Lewis ab61778b87 scaffolder: remove fetch:template extensions todo
cf. https://github.com/backstage/backstage/pull/6322/commits/944fda210ea807f52ece3272736b090ecd1a3a57#r663007257

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-07-06 11:16:59 +02:00
Mike Lewis a8ded61923 scaffolder: add cookiecutter compat mode to fetch:template
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-07-06 11:12:58 +02:00
Mike Lewis 9fba3e22b1 scaffolder: add test suite for fetch:template
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-07-06 11:12:58 +02:00
Mike Lewis 5144e7617d scaffolder: input type from fetch:template action factory
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-07-06 11:12:58 +02:00